You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by afine <gi...@git.apache.org> on 2017/04/18 18:41:11 UTC
[GitHub] zookeeper pull request #231: ZOOKEEPER-2732: Cleanup findbug warnings in bra...
GitHub user afine opened a pull request:
https://github.com/apache/zookeeper/pull/231
ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4: Performance Warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2732
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit fa89cbb73af761e18d17a872b3cd56ac7a22cc87
Author: Abraham Fine <af...@apache.org>
Date: 2017-04-18T18:40:12Z
ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4: Performance Warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #231: ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4...
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/231
+1 LGTM
Could you please rebase PR, as this has following conflict with the latest code - ZOOKEEPER-2759.
`error: patch failed: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java:182`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #231: ZOOKEEPER-2732: Cleanup findbug warnings in bra...
Posted by afine <gi...@git.apache.org>.
Github user afine closed the pull request at:
https://github.com/apache/zookeeper/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #231: ZOOKEEPER-2732: Cleanup findbug warnings in bra...
Posted by afine <gi...@git.apache.org>.
GitHub user afine reopened a pull request:
https://github.com/apache/zookeeper/pull/231
ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4: Performance Warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2732
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #231: ZOOKEEPER-2732: Cleanup findbug warnings in bra...
Posted by afine <gi...@git.apache.org>.
Github user afine closed the pull request at:
https://github.com/apache/zookeeper/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---