[GitHub] [incubator-druid] himanshug commented on issue #8981: add query metrics for broker parallel merges, off by default

[GitBox <gi...@apache.org>]

himanshug commented on issue #8981: add query metrics for broker parallel merges, off by default
URL: https://github.com/apache/incubator-druid/pull/8981#issuecomment-561506572
 
 
   LGTM overall
   
   non blocking commentary....
   
   > Also absent are any sort of aggregate metrics, such as pool utilization over some periodic collection interval or whatever. I would like to look into this as a follow-up, since it seems like there are potentially many metrics that would maybe make sense to collect like this, so I'd like to think a bit harder about how to do this so it's not a one-off solution.
   
   actually periodic snapshot of FJP state would be nice to see to identify potential bugs e.g. number of running threads , total number of threads, queued work etc.
   
   it sucks that to enable these metrics, I would have to write an extension. I haven't read through the thread in  #6559 yet but will hopefully check that out sometime this week.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org