[jira] [Commented] (FLINK-13689) Rest High Level Client for Elasticsearch6.x connector leaks threads if no connection could be established

["static-max (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021282#comment-17021282 ] 

static-max commented on FLINK-13689:
------------------------------------

Hi there, I would like to contribute the changes proposed by [~aljoscha] at [https://github.com/apache/flink/pull/9468].

I already started working on a fix and testing it at the moment. 

> Rest High Level Client for Elasticsearch6.x connector leaks threads if no connection could be established
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-13689
>                 URL: https://issues.apache.org/jira/browse/FLINK-13689
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / ElasticSearch
>    Affects Versions: 1.8.1
>            Reporter: Rishindra Kumar
>            Assignee: Rishindra Kumar
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.8.4
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> If the created Elastic Search Rest High Level Client(rhlClient) is unreachable, Current code throws RuntimeException. But, it doesn't close the client which causes thread leak.
>  
> *Current Code*
> *if (!rhlClient.ping()) {*
>      *throw new RuntimeException("There are no reachable Elasticsearch nodes!");*
> *}*
>  
> *Change Needed*
> rhlClient needs to be closed.
>  
> *Steps to Reproduce*
> 1. Add the ElasticSearch Sink to the stream. Start the Flink program without starting the ElasticSearch. 
> 2. Program will give error: "*Too many open files*" and it doesn't write even though you start the Elastic Search later.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)