You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2024/07/03 01:26:12 UTC
[PR] chore: add unit test for child actor initial exception supervise [pekko]
Roiocam opened a new pull request, #1385:
URL: https://github.com/apache/pekko/pull/1385
Related with #1384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "sadekmunawar (via GitHub)" <gi...@apache.org>.
sadekmunawar commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2234279160
It looks like [the checks](https://github.com/apache/pekko/actions/runs/9835390068/job/27148930769) did not run the tests in `SupervisorHierarchySpec`.
When I ran the tests locally, two tests in `SupervisorHierarchySpec` failed.
- `handle failure in creation when supervision strategy returns Resume and Restart`
- `survive being stressed`
Can someone check if these two unit tests pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2234328588
> It looks like [the checks](https://github.com/apache/pekko/actions/runs/9835390068/job/27148930769) did not run the tests in `SupervisorHierarchySpec`.
>
> When I ran the tests locally, two tests in `SupervisorHierarchySpec` failed.
>
> * `handle failure in creation when supervision strategy returns Resume and Restart`
> * `survive being stressed`
>
> Can someone check if these two unit tests pass?
Those tests are tagged as long-running tests. Maybe such tests are not run by default.
Did those tests fail before this PR was added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2210767720
> > Would you like to contribute this to the Pekko community?
>
> @pjfanning Am I doing this correctly, may I ask?
The test code was written by https://discuss.lightbend.com/u/nodeninja/summary
@sadekmunawar can you confirm if that is you? We received your iCLA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2235457133
I will investigate it. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: add unit test for child actor initial exception supervise [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1663521880
##########
actor-tests/src/test/scala/org/apache/pekko/actor/SupervisorSpec.scala:
##########
@@ -95,6 +95,14 @@ object SupervisorSpec {
}
}
+ class Child(cnt: Int) extends Actor {
Review Comment:
seems like we need closing over the origin AtomicInteger because the restart will keep the actor state instead of recreate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1667334567
##########
actor/src/main/scala/org/apache/pekko/actor/dungeon/FaultHandling.scala:
##########
@@ -214,34 +214,34 @@ private[pekko] trait FaultHandling { this: ActorCell =>
@InternalStableApi
final def handleInvokeFailure(childrenNotToSuspend: immutable.Iterable[ActorRef], t: Throwable): Unit = {
// prevent any further messages to be processed until the actor has been restarted
- if (!isFailed)
Review Comment:
> why is this check not needed?
he move the check to match case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2213247570
> I also wrote a scala version of this test in `ActorLifCyleSpec`. Feel free to use either version of the test
Thanks, I have updated this PR and verified it works in locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1668151381
##########
actor/src/main/scala/org/apache/pekko/actor/dungeon/FaultHandling.scala:
##########
@@ -214,34 +214,34 @@ private[pekko] trait FaultHandling { this: ActorCell =>
@InternalStableApi
final def handleInvokeFailure(childrenNotToSuspend: immutable.Iterable[ActorRef], t: Throwable): Unit = {
// prevent any further messages to be processed until the actor has been restarted
- if (!isFailed)
Review Comment:
the original code didn't use `setFailed()`, so we have no chance to update `actorRef`, and then we will get an assertion failed(the original issue)
This PR used `setFailed()` in exception handling, but we still need send a system message to ourself(to continue handling faults).
I think this check is the real problem that led to the original issue, and my PR removal check is to fix this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2210583711
@sadekmunawar Hi, my unit test partly refers to your code in #1383 links.
Would you like to contribute this to the Pekko community?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "sadekmunawar (via GitHub)" <gi...@apache.org>.
sadekmunawar commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2210879087
> The test code was written by https://discuss.lightbend.com/u/nodeninja/summary
>
> @sadekmunawar can you confirm if that is you? We received your iCLA.
>
@pjfanning yes, that's me. After finding the bug, I wrote that test for a solution I implemented. My solution converts the `FatallyFailed` into a case class and attaches an Optional ActorRef to it.
I also wrote a scala version of this test in `ActorLifCyleSpec`. Feel free to use either version of the test
`"must not break supervisor strategy due to unhandled exception in preStart" in {
val id = newUuid.toString
val gen = new AtomicInteger(0)
val maxRetryNum = 3
val childProps = Props(new LifeCycleTestActor(testActor, id, gen) {
override def preStart(): Unit = {
report("preStart")
throw new Exception("test exception")
}
}).withDeploy(Deploy.local)
val supervisorStrategy: SupervisorStrategy =
OneForOneStrategy(maxNrOfRetries = maxRetryNum, timeout.duration) {
case _: ActorInitializationException => SupervisorStrategy.Restart
case _ => SupervisorStrategy.Escalate
}
val supervisor = system.actorOf(Props(classOf[Supervisor], supervisorStrategy))
Await.result((supervisor ? childProps).mapTo[ActorRef], timeout.duration)
(0 to maxRetryNum).foreach(i => {
expectMsg(("preStart", id, i))
})
expectNoMessage()
system.stop(supervisor)
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1668131373
##########
actor-tests/src/test/scala/org/apache/pekko/actor/ActorLifeCycleSpec.scala:
##########
@@ -160,6 +160,33 @@ class ActorLifeCycleSpec extends PekkoSpec with BeforeAndAfterEach with Implicit
a ! "hello"
expectMsg(42)
}
+
+ "not break supervisor strategy due to unhandled exception in preStart" in {
Review Comment:
Contributed by @sadekmunawar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2229504366
@Roiocam should we backport this to this 1.0.x branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: add unit test for child actor initial exception supervise [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1663617603
##########
actor/src/main/scala/org/apache/pekko/actor/ActorCell.scala:
##########
@@ -643,7 +643,7 @@ private[pekko] class ActorCell(
def failActor(): Unit =
if (_actor != null) {
clearActorFields(actor, recreate = false)
- setFailedFatally()
+ setFailed(actor.self)
Review Comment:
(these links to Akka PRs are OK because they're old, pre-BSL PRs :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: add unit test for child actor initial exception supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1663959364
##########
actor-tests/src/test/scala/org/apache/pekko/actor/SupervisorSpec.scala:
##########
@@ -95,6 +95,14 @@ object SupervisorSpec {
}
}
+ class Child(cnt: Int) extends Actor {
Review Comment:
I think this is ok... Because we were using creator.
https://github.com/apache/pekko/blob/46c557424d19bb2d07adf2fbd55351a8187ff359/actor/src/main/scala/org/apache/pekko/actor/Props.scala#L87-L88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: add unit test for child actor initial exception supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2204882726
From the perspective of stack frame, the problem lies in the handling:
https://github.com/apache/pekko/blob/46c557424d19bb2d07adf2fbd55351a8187ff359/actor/src/main/scala/org/apache/pekko/actor/dungeon/FaultHandling.scala#L160
```
[ERROR] [07/03/2024 09:46:12.113] [SupervisorSpec-pekko.actor.default-dispatcher-5] [pekko://SupervisorSpec/user/$a/$a] changing Recreate into Create after org.apache.pekko.actor.ActorInitializationException: pekko://SupervisorSpec/user/$a/$a: exception during creation, root cause message: [deliberate test failure]
[ERROR] [07/03/2024 09:46:12.114] [SupervisorSpec-pekko.actor.default-dispatcher-6] [pekko://SupervisorSpec/user/$a/$a] assertion failed
java.lang.AssertionError: assertion failed
at scala.Predef$.assert(Predef.scala:264)
at org.apache.pekko.actor.dungeon.FaultHandling.faultCreate(FaultHandling.scala:160)
at org.apache.pekko.actor.dungeon.FaultHandling.faultCreate$(FaultHandling.scala:158)
at org.apache.pekko.actor.ActorCell.faultCreate(ActorCell.scala:420)
at org.apache.pekko.actor.dungeon.FaultHandling.faultRecreate(FaultHandling.scala:96)
at org.apache.pekko.actor.dungeon.FaultHandling.faultRecreate$(FaultHandling.scala:92)
at org.apache.pekko.actor.ActorCell.faultRecreate(ActorCell.scala:420)
at org.apache.pekko.actor.ActorCell.invokeAll$1(ActorCell.scala:526)
at org.apache.pekko.actor.ActorCell.systemInvoke(ActorCell.scala:545)
at org.apache.pekko.dispatch.Mailbox.processAllSystemMessages(Mailbox.scala:297)
at org.apache.pekko.dispatch.Mailbox.run(Mailbox.scala:232)
at org.apache.pekko.dispatch.Mailbox.exec(Mailbox.scala:245)
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: add unit test for child actor initial exception supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1663420764
##########
actor/src/main/scala/org/apache/pekko/actor/ActorCell.scala:
##########
@@ -643,7 +643,7 @@ private[pekko] class ActorCell(
def failActor(): Unit =
if (_actor != null) {
clearActorFields(actor, recreate = false)
- setFailedFatally()
+ setFailed(actor.self)
Review Comment:
I am not sure if this change will break other cases or not, I will investigate later.
relate PR:
- https://github.com/akka/akka/pull/29098/files
- https://github.com/akka/akka/pull/27614/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2210585774
> Would you like to contribute this to the Pekko community?
@pjfanning Am I doing this correctly, may I ask?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2229763530
> @Roiocam should we backport this to this 1.0.x branch?
Of course, this is a bug. backport on #1396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: add unit test for child actor initial exception supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1663554394
##########
actor/src/main/scala/org/apache/pekko/actor/ActorCell.scala:
##########
@@ -643,7 +643,7 @@ private[pekko] class ActorCell(
def failActor(): Unit =
if (_actor != null) {
clearActorFields(actor, recreate = false)
- setFailedFatally()
+ setFailed(actor.self)
Review Comment:
After investigation, we can not set the fault state here... otherwise, we can distinguish between fatal and normal fault
##########
actor/src/main/scala/org/apache/pekko/actor/ActorCell.scala:
##########
@@ -643,7 +643,7 @@ private[pekko] class ActorCell(
def failActor(): Unit =
if (_actor != null) {
clearActorFields(actor, recreate = false)
- setFailedFatally()
+ setFailed(actor.self)
Review Comment:
After investigation, we can not set the fault state here... otherwise, we can not distinguish between fatal and normal fault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1385:
URL: https://github.com/apache/pekko/pull/1385#discussion_r1666842095
##########
actor/src/main/scala/org/apache/pekko/actor/dungeon/FaultHandling.scala:
##########
@@ -214,34 +214,34 @@ private[pekko] trait FaultHandling { this: ActorCell =>
@InternalStableApi
final def handleInvokeFailure(childrenNotToSuspend: immutable.Iterable[ActorRef], t: Throwable): Unit = {
// prevent any further messages to be processed until the actor has been restarted
- if (!isFailed)
Review Comment:
why is this check not needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: add unit test for child actor initial exception supervise [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2205138460
I think we can attach a test case for this, will look into this over the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2211717814
lgtm.
Although I have read the relevant code, I did not delve into testing and debugging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2235778901
both `survive being stressed` and `handle failure in creation when supervision strategy returns Resume and Restart
` has passes in my local by using #1399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "sadekmunawar (via GitHub)" <gi...@apache.org>.
sadekmunawar commented on PR #1385:
URL: https://github.com/apache/pekko/pull/1385#issuecomment-2235044679
> Did those tests fail before this PR was added?
No, they passed in my local workspace before this PR was added. Unless there's something wrong with my local setup, this PR is the likely cause of the failures. I ran into issues with these two unit tests when experimenting with my own fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: resolves and addition tests for child preStart supervise [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1385:
URL: https://github.com/apache/pekko/pull/1385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org