You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@gmail.com> on 2021/03/14 09:39:48 UTC

[VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

This is the vote thread (second attempt) to release a new bug fix
release for the
release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
supersede all the previous releases from the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

and are:
* apache-ofbiz-17.12.06.zip
* KEYS: text file with keys
* apache-ofbiz-17.12.06.zip.asc: the detached signature file
* apache-ofbiz-17.12.06.zip.sha512: checksum file

Please download and test the zip file and its signatures (for
instructions on testing the signatures see
http://www.apache.org/info/verification.html).

Vote:
[ +1] release as Apache OFBiz 17.12.06
[ -1] do not release

This vote will be open for 5 days.
For more details about this process please read
http://www.apache.org/foundation/voting.html

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Nicola Mazzoni <ni...@mpstyle.it>.
+1

Il dom 14 mar 2021, 10:40 Jacopo Cappellato <ja...@gmail.com>
ha scritto:

> This is the vote thread (second attempt) to release a new bug fix
> release for the
> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.06.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 17.12.06
> [ -1] do not release
>
> This vote will be open for 5 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
>

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Michael Brohl <mi...@ecomify.de>.
+1

I've checked again while testing the verify script and this time all 
tests pass on the 1st attempt.

Thanks,

Michael


Am 14.03.21 um 10:39 schrieb Jacopo Cappellato:
> This is the vote thread (second attempt) to release a new bug fix
> release for the
> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.06.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 17.12.06
> [ -1] do not release
>
> This vote will be open for 5 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html

Re: [VOTE] [RESULT] Apache OFBiz 17.12.06 - Second attempt

Posted by r00t 4dm <r0...@gmail.com>.
Thanks Jacopo.

r00t4dm
Cloud-Penetrating Arrow Lab of Meituan Corp Information Security Department

> 2021年3月19日 下午7:38,Jacopo Cappellato <ja...@gmail.com> 写道:
> 
> The release vote is successful with 9 positive votes (of which 8 are
> binding votes) and no negative votes: thank you all!
> 
> I am going to proceed with the next steps and we will announce the new
> release in a few days from now.
> 
> Jacopo
> 
> 
> On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato
> <ja...@gmail.com> wrote:
>> 
>> This is the vote thread (second attempt) to release a new bug fix
>> release for the
>> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
>> supersede all the previous releases from the same branch.
>> 
>> The release files can be downloaded from here:
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>> 
>> and are:
>> * apache-ofbiz-17.12.06.zip
>> * KEYS: text file with keys
>> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
>> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>> 
>> Please download and test the zip file and its signatures (for
>> instructions on testing the signatures see
>> http://www.apache.org/info/verification.html).
>> 
>> Vote:
>> [ +1] release as Apache OFBiz 17.12.06
>> [ -1] do not release
>> 
>> This vote will be open for 5 days.
>> For more details about this process please read
>> http://www.apache.org/foundation/voting.html


[VOTE] [RESULT] Apache OFBiz 17.12.06 - Second attempt

Posted by Jacopo Cappellato <ja...@gmail.com>.
The release vote is successful with 9 positive votes (of which 8 are
binding votes) and no negative votes: thank you all!

I am going to proceed with the next steps and we will announce the new
release in a few days from now.

Jacopo


On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato
<ja...@gmail.com> wrote:
>
> This is the vote thread (second attempt) to release a new bug fix
> release for the
> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.06.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 17.12.06
> [ -1] do not release
>
> This vote will be open for 5 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Nicolas Malin <ni...@nereide.fr>.
+1

All tests passed on debian 10.7 and AdoptOpenJDK build 1.8.0_282-b08

Nicolas

On 14/03/2021 10:39, Jacopo Cappellato wrote:
> This is the vote thread (second attempt) to release a new bug fix
> release for the
> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.06.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 17.12.06
> [ -1] do not release
>
> This vote will be open for 5 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Michael Brohl <mi...@ecomify.de>.
Like Jacques, I had to do a second pass of

./gradlew cleanAll loadAll testIntegration

and then the build was successful.

Everything else worked fine:

~/Projects/apache-ofbiz/dist  ../ofbiz-tools/download-ofbiz-release.sh 
apache-ofbiz-17.12.06
Getting files for $ZIP...

--2021-03-14 11:27:10-- https://dist.apache.org/repos/dist/dev/ofbiz/KEYS
Resolving dist.apache.org (dist.apache.org)... 13.90.137.153
Connecting to dist.apache.org (dist.apache.org)|13.90.137.153|:443... 
connected.
HTTP request sent, awaiting response... 200 OK
Length: 21796 (21K) [text/plain]
Saving to: 'KEYS'

KEYS 
100%[=============================================================================================================================================================================>] 
21.29K  --.-KB/s    in 0.1s

2021-03-14 11:27:11 (189 KB/s) - 'KEYS' saved [21796/21796]

--2021-03-14 11:27:11-- 
https://dist.apache.org/repos/dist/dev/ofbiz/apache-ofbiz-17.12.06.zip
Resolving dist.apache.org (dist.apache.org)... 13.90.137.153
Connecting to dist.apache.org (dist.apache.org)|13.90.137.153|:443... 
connected.
HTTP request sent, awaiting response... 200 OK
Length: 31649438 (30M) [application/zip]
Saving to: 'apache-ofbiz-17.12.06.zip'

apache-ofbiz-17.12.06.zip 
100%[=============================================================================================================================================================================>] 
30.18M  5.52MB/s    in 6.4s

2021-03-14 11:27:18 (4.70 MB/s) - 'apache-ofbiz-17.12.06.zip' saved 
[31649438/31649438]

--2021-03-14 11:27:18-- 
https://dist.apache.org/repos/dist/dev/ofbiz/apache-ofbiz-17.12.06.zip.asc
Resolving dist.apache.org (dist.apache.org)... 13.90.137.153
Connecting to dist.apache.org (dist.apache.org)|13.90.137.153|:443... 
connected.
HTTP request sent, awaiting response... 200 OK
Length: 841 [text/plain]
Saving to: 'apache-ofbiz-17.12.06.zip.asc'

apache-ofbiz-17.12.06.zip.asc 
100%[=============================================================================================================================================================================>] 
841  --.-KB/s    in 0s

2021-03-14 11:27:19 (10.2 MB/s) - 'apache-ofbiz-17.12.06.zip.asc' saved 
[841/841]

--2021-03-14 11:27:19-- 
https://dist.apache.org/repos/dist/dev/ofbiz/apache-ofbiz-17.12.06.zip.sha512
Resolving dist.apache.org (dist.apache.org)... 13.90.137.153
Connecting to dist.apache.org (dist.apache.org)|13.90.137.153|:443... 
connected.
HTTP request sent, awaiting response... 200 OK
Length: 225 [text/plain]
Saving to: 'apache-ofbiz-17.12.06.zip.sha512'

apache-ofbiz-17.12.06.zip.sha512 
100%[=============================================================================================================================================================================>] 
225  --.-KB/s    in 0s

2021-03-14 11:27:20 (2.36 MB/s) - 'apache-ofbiz-17.12.06.zip.sha512' 
saved [225/225]

Done!

~/Projects/apache-ofbiz/dist  ../ofbiz-tools/verify-ofbiz-release.sh 
apache-ofbiz-17.12.06.zip
sha check of file: apache-ofbiz-17.12.06.zip
Using sha file: apache-ofbiz-17.12.06.zip.sha512
apache-ofbiz-17.12.06.zip: 3B302353 D03A7B23 E4E42CDC 1A0257AE 2D29D9B7 
89E6F91A 70DB8539 CF701E63 217F86FF 174325EC 67CD5C61 6E952A8F 286C7CA8 
677CAB5F FE431FB7 4BA9166C
apache-ofbiz-17.12.06.zip: 3B302353 D03A7B23 E4E42CDC 1A0257AE 2D29D9B7 
89E6F91A 70DB8539 CF701E63 217F86FF 174325EC 67CD5C61 6E952A8F 286C7CA8 
677CAB5F FE431FB7 4BA9166C
sha checksum OK

GPG verification output
gpg: Signature made Sun Mar 14 10:19:25 2021 CET
gpg:                using RSA key 7A580908847AF9E0
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) 
<ja...@apache.org>" [ultimate]


unzip apache-ofbiz-17.12.06.zip
...

cd apache-ofbiz-17.12.06

~/Projects/apache-ofbiz/dist/apache-ofbiz-17.12.06  
./gradle/init-gradle-wrapper.sh
  === Prepare operation ===
/Users/mbrohl/Projects/apache-ofbiz/dist/apache-ofbiz-17.12.06/gradle/wrapper/gradle-wrapper.jar 
not found, we download it
  === Download gradle-wrapper.jar ===
  === Control downloaded files ===
gradle/wrapper/gradle-wrapper.jar: OK
gradle/wrapper/gradle-wrapper.properties: OK
gradlew: OK

./gradlew cleanAll loadAll testIntegration

...
first pass failes

2nd pass worked.

Thanks,

Michael

Am 14.03.21 um 12:19 schrieb Jacopo Cappellato:
> weird, I didn't notice the errors and all tests were successful.
>
> Jacopo
>
> On Sun, Mar 14, 2021 at 11:40 AM Michael Brohl <mi...@ecomify.de> wrote:
>> -1
>>
>> Unfortunately I get several Freemarker errors during
>>
>> ./gradlew cleanAll loadAll testIntegration
>>
>> like this
>>
>> 2021-03-14 11:34:49,334 |main |ServiceDispatcher             |T| Sync
>> service [test-dispatcher-R437fRXV8X/getPartyEmail] finished in [2]
>> milliseconds
>> 2021-03-14 11:34:49,336 |main |FreeMarkerWorker              |E| null
>> freemarker.core.InvalidReferenceException: The following has evaluated
>> to null or missing:
>> ==> person  [in template
>> "component://scrum/template/AcceptedBacklogNotification.ftl" at line 25,
>> column 20]
>>
>> ----
>> Tip: If the failing expression is known to legally refer to something
>> that's sometimes null or missing, either specify a default value like
>> myOptionalVar!myDefault, or use <#if
>> myOptionalVar??>when-present<#else>when-missing</#if>. (These only cover
>> the last step of the expression; to cover the whole expression, use
>> parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>> ----
>>
>> ----
>> FTL stack trace ("~" means nesting-related):
>>           - Failed at: ${person.firstName!}  [in template
>> "component://scrum/template/AcceptedBacklogNotification.ftl" at line 25,
>> column 18]
>> ----
>>           at
>> freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:134)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.UnexpectedTypeException.newDesciptionBuilder(UnexpectedTypeException.java:85)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.UnexpectedTypeException.<init>(UnexpectedTypeException.java:48)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.NonHashException.<init>(NonHashException.java:49)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Dot._eval(Dot.java:48)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Expression.eval(Expression.java:83)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.DefaultToExpression._eval(DefaultToExpression.java:88)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Expression.eval(Expression.java:83)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.DollarVariable.calculateInterpolatedStringOrMarkup(DollarVariable.java:100)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.DollarVariable.accept(DollarVariable.java:63)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Environment.visit(Environment.java:330)
>> [freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Environment.visit(Environment.java:336)
>> [freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Environment.process(Environment.java:309)
>> [freemarker-2.3.28.jar:2.3.28]
>>           at
>> org.apache.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:227)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:163)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:200)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.HtmlWidget.renderWidgetString(HtmlWidget.java:139)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:1321)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:284)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:506)
>> [ofbiz.jar:?]
>>           at sun.reflect.GeneratedMethodAccessor404.invoke(Unknown
>> Source) ~[?:?]
>>           at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> ~[?:1.8.0_282]
>>           at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_282]
>>           at
>> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:403)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:403)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:502)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.conditional.MasterIf.exec(MasterIf.java:81)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.callops.CallSimpleMethod.exec(CallSimpleMethod.java:112)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:287)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:85)
>> [ofbiz.jar:?]
>>           at junit.framework.TestSuite.runTest(TestSuite.java:255)
>> [junit-4.11.jar:?]
>>           at junit.framework.TestSuite.run(TestSuite.java:250)
>> [junit-4.11.jar:?]
>>           at
>> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:89)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:218)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
>> [ofbiz.jar:?]
>>           at org.apache.ofbiz.base.start.Start.main(Start.java:85)
>> [ofbiz.jar:?]
>>
>>
>> Could there be a problem with the downgrade of Freemarker in commit
>> 9dd2a255e95c10588004e4fdfb794ab23d173103 ?
>>
>> Thanks,
>>
>> Michael
>>
>> Am 14.03.21 um 10:39 schrieb Jacopo Cappellato:
>>> This is the vote thread (second attempt) to release a new bug fix
>>> release for the
>>> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
>>> supersede all the previous releases from the same branch.
>>>
>>> The release files can be downloaded from here:
>>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>>
>>> and are:
>>> * apache-ofbiz-17.12.06.zip
>>> * KEYS: text file with keys
>>> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
>>> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>>>
>>> Please download and test the zip file and its signatures (for
>>> instructions on testing the signatures see
>>> http://www.apache.org/info/verification.html).
>>>
>>> Vote:
>>> [ +1] release as Apache OFBiz 17.12.06
>>> [ -1] do not release
>>>
>>> This vote will be open for 5 days.
>>> For more details about this process please read
>>> http://www.apache.org/foundation/voting.html

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Jacques Le Roux <ja...@les7arts.com>.
+1

Works here on Windows:

Jacques@LDLC MINGW64 /C/projectsASF/Git/ofbiz-framework/tools (master)
$ ./verify-ofbiz-release.sh apache-ofbiz-17.12.06.zip

    sha check of file: apache-ofbiz-17.12.06.zip
    Using sha file: apache-ofbiz-17.12.06.zip.sha512
    apache-ofbiz-17.12.06.zip: 3B302353 D03A7B23 E4E42CDC 1A0257AE 2D29D9B7 89E6F91A 70DB8539 CF701E63 217F86FF 174325EC 67CD5C61 6E952A8F 286C7CA8
    677CAB5F FE431FB7 4BA9166C
    apache-ofbiz-17.12.06.zip: 3B302353 D03A7B23 E4E42CDC 1A0257AE 2D29D9B7 89E6F91A 70DB8539 CF701E63 217F86FF 174325EC 67CD5C61 6E952A8F 286C7CA8
    677CAB5F FE431FB7 4BA9166C
    sha checksum OK

    GPG verification output
    gpg: Signature made Sun Mar 14 10:19:25 2021
    gpg:                using RSA key 7A580908847AF9E0
    gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) <ja...@apache.org>" [unknown]

     > Task :createTestReports
    Trying to override old definition of datatype junitreport
    [ant:junitreport] the file C:\projectsASF\Git\ofbiz-framework\tools\apache-ofbiz-17.12.06\runtime\logs\test-results\TESTS-TestSuites.xml is not a
    valid testsuite XML document

gradlew  --stacktrace testIntegration

    Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
    See https://docs.gradle.org/4.5.1/userguide/command_line_interface.html#sec:command_line_warnings

    BUILD SUCCESSFUL in 6m 56s
    7 actionable tasks: 2 executed, 5 up-to-date
    C:\projectsASF\Git\ofbiz-framework\tools\apache-ofbiz-17.12.06>

I had though to do twice the testIntegration.

Jacques

Le 14/03/2021 à 12:19, Jacopo Cappellato a écrit :
> weird, I didn't notice the errors and all tests were successful.
>
> Jacopo
>
> On Sun, Mar 14, 2021 at 11:40 AM Michael Brohl <mi...@ecomify.de> wrote:
>> -1
>>
>> Unfortunately I get several Freemarker errors during
>>
>> ./gradlew cleanAll loadAll testIntegration
>>
>> like this
>>
>> 2021-03-14 11:34:49,334 |main |ServiceDispatcher             |T| Sync
>> service [test-dispatcher-R437fRXV8X/getPartyEmail] finished in [2]
>> milliseconds
>> 2021-03-14 11:34:49,336 |main |FreeMarkerWorker              |E| null
>> freemarker.core.InvalidReferenceException: The following has evaluated
>> to null or missing:
>> ==> person  [in template
>> "component://scrum/template/AcceptedBacklogNotification.ftl" at line 25,
>> column 20]
>>
>> ----
>> Tip: If the failing expression is known to legally refer to something
>> that's sometimes null or missing, either specify a default value like
>> myOptionalVar!myDefault, or use <#if
>> myOptionalVar??>when-present<#else>when-missing</#if>. (These only cover
>> the last step of the expression; to cover the whole expression, use
>> parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>> ----
>>
>> ----
>> FTL stack trace ("~" means nesting-related):
>>           - Failed at: ${person.firstName!}  [in template
>> "component://scrum/template/AcceptedBacklogNotification.ftl" at line 25,
>> column 18]
>> ----
>>           at
>> freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:134)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.UnexpectedTypeException.newDesciptionBuilder(UnexpectedTypeException.java:85)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.UnexpectedTypeException.<init>(UnexpectedTypeException.java:48)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.NonHashException.<init>(NonHashException.java:49)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Dot._eval(Dot.java:48)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Expression.eval(Expression.java:83)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.DefaultToExpression._eval(DefaultToExpression.java:88)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Expression.eval(Expression.java:83)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.DollarVariable.calculateInterpolatedStringOrMarkup(DollarVariable.java:100)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at
>> freemarker.core.DollarVariable.accept(DollarVariable.java:63)
>> ~[freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Environment.visit(Environment.java:330)
>> [freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Environment.visit(Environment.java:336)
>> [freemarker-2.3.28.jar:2.3.28]
>>           at freemarker.core.Environment.process(Environment.java:309)
>> [freemarker-2.3.28.jar:2.3.28]
>>           at
>> org.apache.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:227)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:163)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:200)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.HtmlWidget.renderWidgetString(HtmlWidget.java:139)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:1321)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:284)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:506)
>> [ofbiz.jar:?]
>>           at sun.reflect.GeneratedMethodAccessor404.invoke(Unknown
>> Source) ~[?:?]
>>           at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> ~[?:1.8.0_282]
>>           at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_282]
>>           at
>> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:403)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:403)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:502)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.conditional.MasterIf.exec(MasterIf.java:81)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.method.callops.CallSimpleMethod.exec(CallSimpleMethod.java:112)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:287)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:85)
>> [ofbiz.jar:?]
>>           at junit.framework.TestSuite.runTest(TestSuite.java:255)
>> [junit-4.11.jar:?]
>>           at junit.framework.TestSuite.run(TestSuite.java:250)
>> [junit-4.11.jar:?]
>>           at
>> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:89)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:218)
>> [ofbiz.jar:?]
>>           at
>> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
>> [ofbiz.jar:?]
>>           at org.apache.ofbiz.base.start.Start.main(Start.java:85)
>> [ofbiz.jar:?]
>>
>>
>> Could there be a problem with the downgrade of Freemarker in commit
>> 9dd2a255e95c10588004e4fdfb794ab23d173103 ?
>>
>> Thanks,
>>
>> Michael
>>
>> Am 14.03.21 um 10:39 schrieb Jacopo Cappellato:
>>> This is the vote thread (second attempt) to release a new bug fix
>>> release for the
>>> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
>>> supersede all the previous releases from the same branch.
>>>
>>> The release files can be downloaded from here:
>>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>>
>>> and are:
>>> * apache-ofbiz-17.12.06.zip
>>> * KEYS: text file with keys
>>> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
>>> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>>>
>>> Please download and test the zip file and its signatures (for
>>> instructions on testing the signatures see
>>> http://www.apache.org/info/verification.html).
>>>
>>> Vote:
>>> [ +1] release as Apache OFBiz 17.12.06
>>> [ -1] do not release
>>>
>>> This vote will be open for 5 days.
>>> For more details about this process please read
>>> http://www.apache.org/foundation/voting.html


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Jacopo Cappellato <ja...@gmail.com>.
weird, I didn't notice the errors and all tests were successful.

Jacopo

On Sun, Mar 14, 2021 at 11:40 AM Michael Brohl <mi...@ecomify.de> wrote:
>
> -1
>
> Unfortunately I get several Freemarker errors during
>
> ./gradlew cleanAll loadAll testIntegration
>
> like this
>
> 2021-03-14 11:34:49,334 |main |ServiceDispatcher             |T| Sync
> service [test-dispatcher-R437fRXV8X/getPartyEmail] finished in [2]
> milliseconds
> 2021-03-14 11:34:49,336 |main |FreeMarkerWorker              |E| null
> freemarker.core.InvalidReferenceException: The following has evaluated
> to null or missing:
> ==> person  [in template
> "component://scrum/template/AcceptedBacklogNotification.ftl" at line 25,
> column 20]
>
> ----
> Tip: If the failing expression is known to legally refer to something
> that's sometimes null or missing, either specify a default value like
> myOptionalVar!myDefault, or use <#if
> myOptionalVar??>when-present<#else>when-missing</#if>. (These only cover
> the last step of the expression; to cover the whole expression, use
> parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
> ----
>
> ----
> FTL stack trace ("~" means nesting-related):
>          - Failed at: ${person.firstName!}  [in template
> "component://scrum/template/AcceptedBacklogNotification.ftl" at line 25,
> column 18]
> ----
>          at
> freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:134)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at
> freemarker.core.UnexpectedTypeException.newDesciptionBuilder(UnexpectedTypeException.java:85)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at
> freemarker.core.UnexpectedTypeException.<init>(UnexpectedTypeException.java:48)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at
> freemarker.core.NonHashException.<init>(NonHashException.java:49)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at freemarker.core.Dot._eval(Dot.java:48)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at freemarker.core.Expression.eval(Expression.java:83)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at
> freemarker.core.DefaultToExpression._eval(DefaultToExpression.java:88)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at freemarker.core.Expression.eval(Expression.java:83)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at
> freemarker.core.DollarVariable.calculateInterpolatedStringOrMarkup(DollarVariable.java:100)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at
> freemarker.core.DollarVariable.accept(DollarVariable.java:63)
> ~[freemarker-2.3.28.jar:2.3.28]
>          at freemarker.core.Environment.visit(Environment.java:330)
> [freemarker-2.3.28.jar:2.3.28]
>          at freemarker.core.Environment.visit(Environment.java:336)
> [freemarker-2.3.28.jar:2.3.28]
>          at freemarker.core.Environment.process(Environment.java:309)
> [freemarker-2.3.28.jar:2.3.28]
>          at
> org.apache.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:227)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.widget.model.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:163)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.widget.model.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:200)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.widget.model.HtmlWidget.renderWidgetString(HtmlWidget.java:139)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.widget.model.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:1321)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:284)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:506)
> [ofbiz.jar:?]
>          at sun.reflect.GeneratedMethodAccessor404.invoke(Unknown
> Source) ~[?:?]
>          at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_282]
>          at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_282]
>          at
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:403)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:403)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:502)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.method.conditional.MasterIf.exec(MasterIf.java:81)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.method.callops.CallSimpleMethod.exec(CallSimpleMethod.java:112)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:287)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:85)
> [ofbiz.jar:?]
>          at junit.framework.TestSuite.runTest(TestSuite.java:255)
> [junit-4.11.jar:?]
>          at junit.framework.TestSuite.run(TestSuite.java:250)
> [junit-4.11.jar:?]
>          at
> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:89)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:218)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.base.start.Start.main(Start.java:85)
> [ofbiz.jar:?]
>
>
> Could there be a problem with the downgrade of Freemarker in commit
> 9dd2a255e95c10588004e4fdfb794ab23d173103 ?
>
> Thanks,
>
> Michael
>
> Am 14.03.21 um 10:39 schrieb Jacopo Cappellato:
> > This is the vote thread (second attempt) to release a new bug fix
> > release for the
> > release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> > supersede all the previous releases from the same branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> > * apache-ofbiz-17.12.06.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.06.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 17.12.06
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> > For more details about this process please read
> > http://www.apache.org/foundation/voting.html

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Michael Brohl <mi...@ecomify.de>.
-1

Unfortunately I get several Freemarker errors during

./gradlew cleanAll loadAll testIntegration

like this

2021-03-14 11:34:49,334 |main |ServiceDispatcher             |T| Sync 
service [test-dispatcher-R437fRXV8X/getPartyEmail] finished in [2] 
milliseconds
2021-03-14 11:34:49,336 |main |FreeMarkerWorker              |E| null
freemarker.core.InvalidReferenceException: The following has evaluated 
to null or missing:
==> person  [in template 
"component://scrum/template/AcceptedBacklogNotification.ftl" at line 25, 
column 20]

----
Tip: If the failing expression is known to legally refer to something 
that's sometimes null or missing, either specify a default value like 
myOptionalVar!myDefault, or use <#if 
myOptionalVar??>when-present<#else>when-missing</#if>. (These only cover 
the last step of the expression; to cover the whole expression, use 
parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
----

----
FTL stack trace ("~" means nesting-related):
         - Failed at: ${person.firstName!}  [in template 
"component://scrum/template/AcceptedBacklogNotification.ftl" at line 25, 
column 18]
----
         at 
freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:134) 
~[freemarker-2.3.28.jar:2.3.28]
         at 
freemarker.core.UnexpectedTypeException.newDesciptionBuilder(UnexpectedTypeException.java:85) 
~[freemarker-2.3.28.jar:2.3.28]
         at 
freemarker.core.UnexpectedTypeException.<init>(UnexpectedTypeException.java:48) 
~[freemarker-2.3.28.jar:2.3.28]
         at 
freemarker.core.NonHashException.<init>(NonHashException.java:49) 
~[freemarker-2.3.28.jar:2.3.28]
         at freemarker.core.Dot._eval(Dot.java:48) 
~[freemarker-2.3.28.jar:2.3.28]
         at freemarker.core.Expression.eval(Expression.java:83) 
~[freemarker-2.3.28.jar:2.3.28]
         at 
freemarker.core.DefaultToExpression._eval(DefaultToExpression.java:88) 
~[freemarker-2.3.28.jar:2.3.28]
         at freemarker.core.Expression.eval(Expression.java:83) 
~[freemarker-2.3.28.jar:2.3.28]
         at 
freemarker.core.DollarVariable.calculateInterpolatedStringOrMarkup(DollarVariable.java:100) 
~[freemarker-2.3.28.jar:2.3.28]
         at 
freemarker.core.DollarVariable.accept(DollarVariable.java:63) 
~[freemarker-2.3.28.jar:2.3.28]
         at freemarker.core.Environment.visit(Environment.java:330) 
[freemarker-2.3.28.jar:2.3.28]
         at freemarker.core.Environment.visit(Environment.java:336) 
[freemarker-2.3.28.jar:2.3.28]
         at freemarker.core.Environment.process(Environment.java:309) 
[freemarker-2.3.28.jar:2.3.28]
         at 
org.apache.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:227) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.widget.model.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:163) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.widget.model.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:200) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.widget.model.HtmlWidget.renderWidgetString(HtmlWidget.java:139) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.widget.model.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:1321) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:284) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:506) 
[ofbiz.jar:?]
         at sun.reflect.GeneratedMethodAccessor404.invoke(Unknown 
Source) ~[?:?]
         at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 
~[?:1.8.0_282]
         at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_282]
         at 
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:403) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:403) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:502) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.method.conditional.MasterIf.exec(MasterIf.java:81) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.method.callops.CallSimpleMethod.exec(CallSimpleMethod.java:112) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:287) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:85) 
[ofbiz.jar:?]
         at junit.framework.TestSuite.runTest(TestSuite.java:255) 
[junit-4.11.jar:?]
         at junit.framework.TestSuite.run(TestSuite.java:250) 
[junit-4.11.jar:?]
         at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:89) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:218) 
[ofbiz.jar:?]
         at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71) 
[ofbiz.jar:?]
         at org.apache.ofbiz.base.start.Start.main(Start.java:85) 
[ofbiz.jar:?]


Could there be a problem with the downgrade of Freemarker in commit 
9dd2a255e95c10588004e4fdfb794ab23d173103 ?

Thanks,

Michael

Am 14.03.21 um 10:39 schrieb Jacopo Cappellato:
> This is the vote thread (second attempt) to release a new bug fix
> release for the
> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.06.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 17.12.06
> [ -1] do not release
>
> This vote will be open for 5 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Aditya Sharma <ad...@apache.org>.
+1

All tests passed on macOS Big Sur 11.2.3, AdoptOpenJDK openjdk version
"1.8.0_282" (build 1.8.0_282-b08)

Thanks and Regards,
Aditya Sharma

On Fri, Mar 19, 2021 at 2:19 PM Suraj Khurana <su...@hotwax.co>
wrote:

> +1
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Fri, Mar 19, 2021 at 1:43 PM Jacopo Cappellato <
> jacopo.cappellato@gmail.com> wrote:
>
> > +1
> >
> > Jacopo
> >
> > On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato
> > <ja...@gmail.com> wrote:
> > >
> > > This is the vote thread (second attempt) to release a new bug fix
> > > release for the
> > > release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> > > supersede all the previous releases from the same branch.
> > >
> > > The release files can be downloaded from here:
> > > https://dist.apache.org/repos/dist/dev/ofbiz/
> > >
> > > and are:
> > > * apache-ofbiz-17.12.06.zip
> > > * KEYS: text file with keys
> > > * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> > > * apache-ofbiz-17.12.06.zip.sha512: checksum file
> > >
> > > Please download and test the zip file and its signatures (for
> > > instructions on testing the signatures see
> > > http://www.apache.org/info/verification.html).
> > >
> > > Vote:
> > > [ +1] release as Apache OFBiz 17.12.06
> > > [ -1] do not release
> > >
> > > This vote will be open for 5 days.
> > > For more details about this process please read
> > > http://www.apache.org/foundation/voting.html
> >
>

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Suraj Khurana <su...@hotwax.co>.
+1

--
Best Regards,
Suraj Khurana
Senior Technical Consultant


On Fri, Mar 19, 2021 at 1:43 PM Jacopo Cappellato <
jacopo.cappellato@gmail.com> wrote:

> +1
>
> Jacopo
>
> On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato
> <ja...@gmail.com> wrote:
> >
> > This is the vote thread (second attempt) to release a new bug fix
> > release for the
> > release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> > supersede all the previous releases from the same branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> > * apache-ofbiz-17.12.06.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.06.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 17.12.06
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> > For more details about this process please read
> > http://www.apache.org/foundation/voting.html
>

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Jacopo Cappellato <ja...@gmail.com>.
+1

Jacopo

On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato
<ja...@gmail.com> wrote:
>
> This is the vote thread (second attempt) to release a new bug fix
> release for the
> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.06.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 17.12.06
> [ -1] do not release
>
> This vote will be open for 5 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Jacopo Cappellato <ja...@gmail.com>.
Thank you Justin,

We will definitely double check this issue but I am rather sure it is an
old reference that should be removed from the LICENSE file: afaik the
folder (and its content/subfolders)
birt/webapp/birt/webcontent/
no longer exists and thus it is not distributed in any release.

Jacopo


On Thu, Jun 17, 2021 at 2:16 AM Justin Mclean <jm...@apache.org> wrote:

> Hi,
>
> I could see the some of the files in question covered by that license in
> your source release so I'm not 100% sure that is correct, but I'm not
> familiar with your code base. You might want to double check just to be
> sure.
>
> If it not in the source release then there no need to mention that license
> in the LICNSE file, so yes removing it wold be the right approach.
>
> Kind Regards,
> Justin
>
>

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Justin Mclean <ju...@classsoftware.com>.
HI,

> So as suggested Jacopo (not sure you got a copy), we can remove the mention in LICENSE file. I'll do so right now…

Yes that sounds like the right thing to do to me. Either way it not an issue for this release, having extra info in a license file is just a documentation issue.

Kind Regards,
Justin



Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Justin,

So as suggested Jacopo (not sure you got a copy), we can remove the mention in LICENSE file. I'll do so right now...

Jacques

Le 17/06/2021 à 14:37, Justin Mclean a écrit :
> Hi,
>
>> I did not find any such files.
> Good to hear and I'm sure you're right, as I said I'm not familiar with your codebase. These directories are the ones I noticed:
> ./plugins/birt/widget/birt
> ./plugins/birt/webapp/birt
> ./plugins/birt/src/main/java/org/apache/ofbiz/birt
>
> Kind Regards,
> Justin


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Justin Mclean <jm...@apache.org>.
Hi,

> I did not find any such files. 

Good to hear and I'm sure you're right, as I said I'm not familiar with your codebase. These directories are the ones I noticed:
./plugins/birt/widget/birt
./plugins/birt/webapp/birt
./plugins/birt/src/main/java/org/apache/ofbiz/birt

Kind Regards,
Justin

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Justin,

I did not find any such files. I mean files part of the Birt project. AFAIK we only depends on org.eclipse.birt.runtime:viewservlets:4.5.0 that is 
only "loaded at runtime" bu Gradle (cf https://github.com/apache/ofbiz-plugins/blob/trunk/birt/build.gradle)

So, which files did you find and how did you find them?

TIA

Jacques

Le 17/06/2021 à 02:16, Justin Mclean a écrit :
> Hi,
>
> I could see the some of the files in question covered by that license in your source release so I'm not 100% sure that is correct, but I'm not familiar with your code base. You might want to double check just to be sure.
>
> If it not in the source release then there no need to mention that license in the LICNSE file, so yes removing it wold be the right approach.
>
> Kind Regards,
> Justin
>

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Justin Mclean <jm...@apache.org>.
Hi,

I could see the some of the files in question covered by that license in your source release so I'm not 100% sure that is correct, but I'm not familiar with your code base. You might want to double check just to be sure.

If it not in the source release then there no need to mention that license in the LICNSE file, so yes removing it wold be the right approach.

Kind Regards,
Justin


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Justin,

Actually to avoid embedding several libs with incompatible licenses we use Gradle to build OFBiz since few years now. So the libs are not embedded but 
loaded at "runtime" by Gradle (Gradle uses a local cache).

So I think we should remove this notice (and those alike) in our LICENSE file. Or possibly replace "bundles" by another word to keep this information, 
but I don't see a need for that.

My 2 cts

Jacques

Le 16/06/2021 à 09:53, Justin Mclean a écrit :
> HI,
>
> I'm not on your PMC but I noticed something a little odd with this release . Your LICENSE states:
>
> This product bundles files from the "Birt" technology platform (www.eclipse.org/birt/)
> which are available under the "Eclipse Public License - v 1.0".
> For details, see plugins/birt/webapp/birt/webcontent/birt/
>
> However the EPL license is Category B and can't be included in a source release. [1]
>
> There's probably a good reason for this that I'm unaware of, and I've not looked at this in detail. I just notice something odd, and I thought it best to tell you. I'll leave it up to you if you want to do anything about it.
>
> Kind Regards,
> Justin
>
> 1. https://www.apache.org/legal/resolved.html#binary-only-inclusion-condition


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Justin Mclean <jm...@apache.org>.
HI,

I'm not on your PMC but I noticed something a little odd with this release . Your LICENSE states:

This product bundles files from the "Birt" technology platform (www.eclipse.org/birt/)
which are available under the "Eclipse Public License - v 1.0".
For details, see plugins/birt/webapp/birt/webcontent/birt/

However the EPL license is Category B and can't be included in a source release. [1]

There's probably a good reason for this that I'm unaware of, and I've not looked at this in detail. I just notice something odd, and I thought it best to tell you. I'll leave it up to you if you want to do anything about it.

Kind Regards,
Justin

1. https://www.apache.org/legal/resolved.html#binary-only-inclusion-condition

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Girish Vasmatkar <gi...@hotwaxsystems.com>.
+1

All tests passed on macOS Catalina 10.15.7, openjdk version
"1.8.0_242" (build 1.8.0_242-b08)

Best,
Girish

On Tue, Mar 16, 2021 at 5:39 PM Christian Geisert <
christian.geisert@isu-gmbh.de> wrote:

> +1
>
> (Ubuntu 18.04.5 LTS, openjdk version "1.8.0_282")
>
> Christian
>
>
> Am 14.03.21 um 10:39 schrieb Jacopo Cappellato:
> > This is the vote thread (second attempt) to release a new bug fix
> > release for the
> > release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> > supersede all the previous releases from the same branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> > * apache-ofbiz-17.12.06.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.06.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 17.12.06
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> > For more details about this process please read
> > http://www.apache.org/foundation/voting.html
>
>
>

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

Posted by Christian Geisert <ch...@isu-gmbh.de>.
+1

(Ubuntu 18.04.5 LTS, openjdk version "1.8.0_282")

Christian


Am 14.03.21 um 10:39 schrieb Jacopo Cappellato:
> This is the vote thread (second attempt) to release a new bug fix
> release for the
> release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.06.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> * apache-ofbiz-17.12.06.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 17.12.06
> [ -1] do not release
>
> This vote will be open for 5 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html