[GitHub] [superset] john-bodley commented on a diff in pull request #22013: fix(sqllab): Add templateParams on kv store

[GitBox <gi...@apache.org>]

john-bodley commented on code in PR #22013:
URL: https://github.com/apache/superset/pull/22013#discussion_r1012395241


##########
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx:
##########
@@ -72,6 +72,7 @@ const unsavedQueryEditor = {
   schema: 'query_schema_updated',
   sql: 'SELECT * FROM Updated Limit 100',
   autorun: true,
+  templateParams: '{ "my_value": "foo" }',

Review Comment:
   @justinpark how are these template parameters actually leveraged in the test? It's not apparent to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org