[GitHub] [tvm] wrongtest-intellif commented on pull request #13936: [Arith] Simplifications for floormod(x, 2)

["wrongtest-intellif (via GitHub)" <gi...@apache.org>]

wrongtest-intellif commented on PR #13936:
URL: https://github.com/apache/tvm/pull/13936#issuecomment-1448050771

   BTW for cancellation like `f(x + c1) - f(x + c2)`, it seems generally the pair may not coincide in summation terms. So we would fail to cancel things like `f(x + c1) + g(x + c3) - f(x + c2)` even if we do have the rules. 
   
   For my curiosity about our tradeoff in simplication, may in the future it allows introduce O(n^2) level rewriting for summation terms to fully utilize rewrite rules?  cc @tqchen @Lunderberg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org