You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/26 19:47:09 UTC
[GitHub] [incubator-superset] oashton opened a new pull request #9210: Add
maximize and minimize feature to charts
oashton opened a new pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210
### CATEGORY
Choose one
- [ ] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add a new option in the chart contextual menu:
* The label change between Maximize and Minimize depending of the chart state
* The maximize chart take all the available space in the browser
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Click in the three dots menu in any chart, click the Maximize option.
Click again in the three dots menu in any chart, click the Minimize option.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: #9209
- [X] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r388026836
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -183,6 +200,29 @@ class ChartHolder extends React.Component {
? parentComponent.meta.width || GRID_MIN_COLUMN_COUNT
: component.meta.width || GRID_MIN_COLUMN_COUNT;
+ let fullStyle = {};
+ let w = 0;
+ let h = 0;
+
+ if (this.state.isFullSize) {
+ fullStyle = {
Review comment:
css doesn't use quotes, try removing the quotes (and the `!important`s)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton removed a comment on issue #9210: Add
maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton removed a comment on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-591704722
How do I update a pull request? I already fix the link problems in my fork
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton removed a comment on issue #9210: Add
maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton removed a comment on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-591675126
How do I update the pull request? I'm not sure how to do it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387876600
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -159,9 +171,14 @@ class ChartHolder extends React.Component {
});
}
+ handleFullSize() {
+ const flag = !this.state.isFullSize;
+ this.setState(() => ({ isFullSize: flag, resizeEvent: true }));
+ }
+
render() {
const { isFocused } = this.state;
-
+ const PADDING = 32;
Review comment:
Changed, I reuse another constant at the top of file c0526bd607a84ebc9e32f7d4676af14a06a2624b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on issue #9210: Add
maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
suddjian commented on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593709836
Can you explain what `resizeEvent` does that cannot be done with `isFullSize` alone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387876968
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -159,9 +171,14 @@ class ChartHolder extends React.Component {
});
}
+ handleFullSize() {
+ const flag = !this.state.isFullSize;
Review comment:
`flag `variable deleted c0526bd607a84ebc9e32f7d4676af14a06a2624b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r388347001
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -183,6 +200,29 @@ class ChartHolder extends React.Component {
? parentComponent.meta.width || GRID_MIN_COLUMN_COUNT
: component.meta.width || GRID_MIN_COLUMN_COUNT;
+ let fullStyle = {};
+ let w = 0;
+ let h = 0;
+
+ if (this.state.isFullSize) {
+ fullStyle = {
Review comment:
Done, it worked... c6f99a896a1995d6cd7e214b3d6df4d20bfee288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387876968
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -159,9 +171,14 @@ class ChartHolder extends React.Component {
});
}
+ handleFullSize() {
+ const flag = !this.state.isFullSize;
Review comment:
flag variable deleted c0526bd607a84ebc9e32f7d4676af14a06a2624b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9210: Add
maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1100dd9`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `68.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
========================================
Coverage ? 58.9%
========================================
Files ? 372
Lines ? 12027
Branches ? 2944
========================================
Hits ? 7084
Misses ? 4765
Partials ? 178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `24% <ø> (ø)` | |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.63% <0%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <100%> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `74.68% <66.66%> (ø)` | |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `84.37% <80%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [1100dd9...608ac83](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on issue #9210: Add maximize
and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593656377
@suddjian , do you have any other comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on issue #9210: Add maximize
and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-605217174
@etr2460 , let me know if there is anything left to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on issue #9210: Add maximize
and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-591675126
How do I update the pull request? I'm not sure how to do it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9210:
Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d8fea640f89160f8aeccfcc3702f1fc39ae08fd8?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `42.1%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
- Coverage 58.9% 58.87% -0.03%
==========================================
Files 373 373
Lines 12026 12045 +19
Branches 2953 2957 +4
==========================================
+ Hits 7084 7092 +8
- Misses 4763 4774 +11
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `24% <ø> (ø)` | :arrow_up: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.63% <0%> (-0.99%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25%> (-1.83%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.14% <63.63%> (-2.52%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [d8fea64...a9d912d](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on issue #9210: Add maximize
and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-591704722
How do I update a pull request? I already fix the link problems in my fork
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387875555
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -158,6 +166,8 @@ class SliceHeaderControls extends React.PureComponent {
</MenuItem>
)}
+ {<MenuItem onClick={this.handleFullSize}>{t(resizeLabel)}</MenuItem>}
Review comment:
Changed c0526bd607a84ebc9e32f7d4676af14a06a2624b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387129092
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -183,6 +200,29 @@ class ChartHolder extends React.Component {
? parentComponent.meta.width || GRID_MIN_COLUMN_COUNT
: component.meta.width || GRID_MIN_COLUMN_COUNT;
+ let fullStyle = {};
+ let w = 0;
+ let h = 0;
Review comment:
prefer full word variable names, so `height` and `width` or `chartHeight` and `chartWidth`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387880973
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -183,6 +200,29 @@ class ChartHolder extends React.Component {
? parentComponent.meta.width || GRID_MIN_COLUMN_COUNT
: component.meta.width || GRID_MIN_COLUMN_COUNT;
+ let fullStyle = {};
+ let w = 0;
+ let h = 0;
+
+ if (this.state.isFullSize) {
+ fullStyle = {
Review comment:
I tried to do that
But it shows the following warnings:
I tried different things but nothing work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r389387977
##########
File path: superset-frontend/src/dashboard/stylesheets/components/chart.less
##########
@@ -148,3 +148,10 @@
.time-filter-tabs > .nav-tabs > li > a {
padding: 4px;
}
+
+.full-size-style {
+ position: fixed;
+ z-index: 1000;
+ left: 0px;
+ top: 0px;
+};
Review comment:
a couple nits:
- Name this `full-size`, we know it's applying styling because it's already in css
- Use one of the z-index constants here if one of them works, or add a new one for dashboard modals https://github.com/apache/incubator-superset/blob/7d572d9e9621e6c469d6db0afe650e41fcf297b1/superset-frontend/stylesheets/less/variables.less#L106-L124
- `left` and `top` can just be `0` instead of `0px`
- Remove the semicolon and make sure there's a new line at the end of the file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r389846225
##########
File path: superset-frontend/src/dashboard/stylesheets/components/chart.less
##########
@@ -148,3 +148,10 @@
.time-filter-tabs > .nav-tabs > li > a {
padding: 4px;
}
+
+.full-size-style {
+ position: fixed;
+ z-index: 1000;
+ left: 0px;
+ top: 0px;
+};
Review comment:
Fixed. 301a8f0c57e8999a76e3185fb659d9723d82598f.
I'm curious: why the new line at the end of the file? @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387876034
##########
File path: superset-frontend/src/dashboard/components/SliceHeader.jsx
##########
@@ -46,6 +46,8 @@ const propTypes = {
componentId: PropTypes.string.isRequired,
filters: PropTypes.object.isRequired,
addDangerToast: PropTypes.func.isRequired,
+ handleFullSize: PropTypes.func.isRequired,
+ resizeEvent: PropTypes.bool,
Review comment:
resizeEvent deleted b79ed4fc5348742c102b9e5313669749eb699700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r386650316
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -109,12 +115,14 @@ class SliceHeaderControls extends React.PureComponent {
updatedDttm,
componentId,
addDangerToast,
+ isFullSize,
} = this.props;
const cachedWhen = moment.utc(cachedDttm).fromNow();
const updatedWhen = updatedDttm ? moment.utc(updatedDttm).fromNow() : '';
const refreshTooltip = isCached
? t('Cached %s', cachedWhen)
: (updatedWhen && t('Fetched %s', updatedWhen)) || '';
+ const resizeLabel = isFullSize ? 'Minimize' : 'Maximize';
Review comment:
Should use translations
```suggestion
const resizeLabel = isFullSize ? t('Minimize') : t('Maximize');
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387125454
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -158,6 +166,8 @@ class SliceHeaderControls extends React.PureComponent {
</MenuItem>
)}
+ {<MenuItem onClick={this.handleFullSize}>{t(resizeLabel)}</MenuItem>}
Review comment:
this doesn't need to be wrapped in braces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r388026521
##########
File path: superset-frontend/src/dashboard/components/SliceHeader.jsx
##########
@@ -46,6 +46,8 @@ const propTypes = {
componentId: PropTypes.string.isRequired,
filters: PropTypes.object.isRequired,
addDangerToast: PropTypes.func.isRequired,
+ handleFullSize: PropTypes.func.isRequired,
+ resizeEvent: PropTypes.bool,
Review comment:
looks like it's still in the PR, maybe you missed a commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387846993
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -159,9 +171,14 @@ class ChartHolder extends React.Component {
});
}
+ handleFullSize() {
+ const flag = !this.state.isFullSize;
Review comment:
or `toggledFullSize`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387129541
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -183,6 +200,29 @@ class ChartHolder extends React.Component {
? parentComponent.meta.width || GRID_MIN_COLUMN_COUNT
: component.meta.width || GRID_MIN_COLUMN_COUNT;
+ let fullStyle = {};
+ let w = 0;
+ let h = 0;
+
+ if (this.state.isFullSize) {
+ fullStyle = {
Review comment:
instead of applying style to this inline, couldn't we add a new css class to the component then define the style in a less file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387128465
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -159,9 +171,14 @@ class ChartHolder extends React.Component {
});
}
+ handleFullSize() {
+ const flag = !this.state.isFullSize;
Review comment:
what is this `flag` for? Can we name it something more explicit like `newIsFullSizeState`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r388330427
##########
File path: superset-frontend/src/dashboard/components/SliceHeader.jsx
##########
@@ -46,6 +46,8 @@ const propTypes = {
componentId: PropTypes.string.isRequired,
filters: PropTypes.object.isRequired,
addDangerToast: PropTypes.func.isRequired,
+ handleFullSize: PropTypes.func.isRequired,
+ resizeEvent: PropTypes.bool,
Review comment:
My mistake... fixed f1961d31bc239231178755f38d55eb7caa2af035
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on issue #9210: Add maximize
and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-594720393
> > From what I understood, I needed to add a new conditional to force the update, that condition is the resize event, the `isFullSize` only represent the state not if new event (resize) was triggered.
>
> Okay, I think I understand. I think you could use `nextProps.isfullSize !== this.props.isFullSize`, then you wouldn't need `resizeEvent` anymore.
Perfect, it worked.... I have commit the change b79ed4fc5348742c102b9e5313669749eb699700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on issue #9210: Add
maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
suddjian commented on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-594103040
> From what I understood, I needed to add a new conditional to force the update, that condition is the resize event, the `isFullSize` only represent the state not if new event (resize) was triggered.
Okay, I think I understand. I think you could use `nextProps.isfullSize !== this.props.isFullSize`, then you wouldn't need `resizeEvent` anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387127646
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -107,21 +107,33 @@ class ChartHolder extends React.Component {
outlinedComponentId: null,
outlinedColumnName: null,
directPathLastUpdated: 0,
+ isFullSize: false,
+ resizeEvent: false,
};
this.handleChangeFocus = this.handleChangeFocus.bind(this);
this.handleDeleteComponent = this.handleDeleteComponent.bind(this);
this.handleUpdateSliceName = this.handleUpdateSliceName.bind(this);
+ this.handleFullSize = this.handleFullSize.bind(this);
}
componentDidMount() {
this.hideOutline({}, this.state);
}
componentDidUpdate(prevProps, prevState) {
+ this.finishResizeEvent();
this.hideOutline(prevState, this.state);
}
+ finishResizeEvent() {
+ setTimeout(() => {
+ if (this.state.resizeEvent) {
+ this.setState(() => ({ resizeEvent: false }));
+ }
+ }, 200);
Review comment:
are we guaranteed that the event will end in 200ms? what if something is really slow?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387877208
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -159,9 +171,14 @@ class ChartHolder extends React.Component {
});
}
+ handleFullSize() {
Review comment:
Renamed c0526bd607a84ebc9e32f7d4676af14a06a2624b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387876261
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -107,21 +107,33 @@ class ChartHolder extends React.Component {
outlinedComponentId: null,
outlinedColumnName: null,
directPathLastUpdated: 0,
+ isFullSize: false,
+ resizeEvent: false,
};
this.handleChangeFocus = this.handleChangeFocus.bind(this);
this.handleDeleteComponent = this.handleDeleteComponent.bind(this);
this.handleUpdateSliceName = this.handleUpdateSliceName.bind(this);
+ this.handleFullSize = this.handleFullSize.bind(this);
}
componentDidMount() {
this.hideOutline({}, this.state);
}
componentDidUpdate(prevProps, prevState) {
+ this.finishResizeEvent();
this.hideOutline(prevState, this.state);
}
+ finishResizeEvent() {
+ setTimeout(() => {
+ if (this.state.resizeEvent) {
+ this.setState(() => ({ resizeEvent: false }));
+ }
+ }, 200);
Review comment:
resizeEvent deleted b79ed4fc5348742c102b9e5313669749eb699700, per @suddjian suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387128023
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -159,9 +171,14 @@ class ChartHolder extends React.Component {
});
}
+ handleFullSize() {
+ const flag = !this.state.isFullSize;
+ this.setState(() => ({ isFullSize: flag, resizeEvent: true }));
+ }
+
render() {
const { isFocused } = this.state;
-
+ const PADDING = 32;
Review comment:
prefer defining constants at the top of the file instead of in the render function. Also, could use a more descriptive variable name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387126405
##########
File path: superset-frontend/src/dashboard/components/SliceHeader.jsx
##########
@@ -46,6 +46,8 @@ const propTypes = {
componentId: PropTypes.string.isRequired,
filters: PropTypes.object.isRequired,
addDangerToast: PropTypes.func.isRequired,
+ handleFullSize: PropTypes.func.isRequired,
+ resizeEvent: PropTypes.bool,
Review comment:
if this is a boolean, then it should be probably named something like `isResizeEvent` or `hasResizeEvent`. I'm not quite sure what makes the most sense here, but some renaming would be great
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on issue #9210: Add maximize
and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on issue #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593990492
> Can you explain what `resizeEvent` does that cannot be done with `isFullSize` alone?
The `Chart.jsx shouldComponentUpdate` method has some logic to determine if the chart should update. From what I understood, I needed to add a new conditional to force the update, that condition is the resize event, the `isFullSize` only represent the state not if new event (resize) was triggered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387877328
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -183,6 +200,29 @@ class ChartHolder extends React.Component {
? parentComponent.meta.width || GRID_MIN_COLUMN_COUNT
: component.meta.width || GRID_MIN_COLUMN_COUNT;
+ let fullStyle = {};
+ let w = 0;
+ let h = 0;
Review comment:
Changed c0526bd607a84ebc9e32f7d4676af14a06a2624b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387128700
##########
File path: superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -159,9 +171,14 @@ class ChartHolder extends React.Component {
});
}
+ handleFullSize() {
Review comment:
Can we rename to `handleToggleFullSize` since that seems to be what's happening here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387126787
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -158,6 +166,8 @@ class SliceHeaderControls extends React.PureComponent {
</MenuItem>
)}
+ {<MenuItem onClick={this.handleFullSize}>{t(resizeLabel)}</MenuItem>}
Review comment:
Also, `resizeLabel` shouldn't be wrapped in `t()` again if you've already wrapped the strings in it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-623650468
@villebro , a test commited a couple of hours ago is breaking the checks... where can I report it?
Correction: 4 days ago
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.70% +0.21%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21500 +12643
- Misses 3593 8793 +5200
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.58% <52.63%> (-0.01%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.87% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `87.09% <25.00%> (-2.80%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `73.33% <0.00%> (ø)` | |
| [superset/utils/feature\_flag\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZmVhdHVyZV9mbGFnX21hbmFnZXIucHk=) | `93.75% <0.00%> (ø)` | |
| [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | `88.67% <0.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.35% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/cockroachdb.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NvY2tyb2FjaGRiLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.89% <0.00%> (ø)` | |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-623650468
@villebro , a test commited a couple of hours ago is breaking the checks... where can I report it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624124195
Thanks for the patience @oashton ; it seems CI threw some very unrelated error. I restarted it just in case, but if that doesn't work out we might be better off just reopening a new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-650265470
Thanks again @oashton for this, really cool feature! ❤️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.70% +0.21%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21500 +12643
- Misses 3593 8793 +5200
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.58% <52.63%> (-0.01%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.87% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `87.09% <25.00%> (-2.80%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `97.50% <0.00%> (ø)` | |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (ø)` | |
| [superset/common/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3RhZ3MucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `85.71% <0.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.56% <0.00%> (ø)` | |
| [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `95.45% <0.00%> (ø)` | |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-620015107
@oashton can you rebase this? We've moved off Travis due to problems with PRs getting stuck (this one is also stuck hence can't be merged), and rebasing might fix the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624179662
> Oh, it seems the test problem was already fixed. Would you mind rebasing one more time @oashton ?
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-620963242
@oashton I wonder if something went wrong in the rebase? This is showing 520 files changed with `+66,552 −33,417` rows changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.70% +0.20%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21499 +12642
- Misses 3593 8794 +5201
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.87% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/examples/sf\_population\_polygons.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvc2ZfcG9wdWxhdGlvbl9wb2x5Z29ucy5weQ==) | `29.16% <0.00%> (ø)` | |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `90.90% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `85.71% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (ø)` | |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.71% <0.00%> (ø)` | |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.57% +0.08%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21460 +12603
- Misses 3593 8833 +5240
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.65% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `91.48% <0.00%> (ø)` | |
| [superset/sql\_validators/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvX19pbml0X18ucHk=) | `80.00% <0.00%> (ø)` | |
| [superset/examples/random\_time\_series.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcmFuZG9tX3RpbWVfc2VyaWVzLnB5) | `22.58% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (ø)` | |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624179662
> Oh, it seems the test problem was already fixed. Would you mind rebasing one more time @oashton ?
Done @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-635465579
> @etr2460 as you've reviewed this more in-depth, would you mind taking a look and merging if all is well?
@etr2460 , is there anything left to do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
- Coverage 70.49% 70.46% -0.04%
==========================================
Files 402 402
Lines 12564 12583 +19
Branches 3112 3116 +4
==========================================
+ Hits 8857 8866 +9
- Misses 3593 3603 +10
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **decrease** coverage by `11.61%`.
> The diff coverage is `42.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
===========================================
- Coverage 70.49% 58.88% -11.62%
===========================================
Files 402 402
Lines 12564 12583 +19
Branches 3112 3116 +4
===========================================
- Hits 8857 7409 -1448
- Misses 3593 4990 +1397
- Partials 114 184 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `24.00% <ø> (-32.00%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.63% <0.00%> (-56.81%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-24.30%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.14% <63.63%> (-4.22%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [139 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624049565
> > @oashton I wonder if something went wrong in the rebase? This is showing 520 files changed with `+66,552 −33,417` rows changed.
>
> @villebro , yes... I'm gonna fix it... I'll let you know as soon as a finish
@villebro ... fixed. Let me know if there is anything else to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624125535
Oh, it seems the test problem was already fixed. Would you mind rebasing one more time @oashton ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-650280261
Stoked that this is in! Thanks @oashton!
Paging @Steejay - maybe we can find a home for a slick maximize/minimize toggle button somewhere in the redesign project?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.70% +0.20%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21499 +12642
- Misses 3593 8794 +5201
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.87% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/common/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3RhZ3MucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | `90.90% <0.00%> (ø)` | |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset/views/chart/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvbWl4aW4ucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (ø)` | |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624188940
@etr2460 as you've reviewed this more in-depth, would you mind taking a look and merging if all is well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-620897549
> @oashton can you rebase this? We've moved off Travis due to problems with PRs getting stuck (this one is also stuck hence can't be merged), and rebasing might fix the problem.
@villebro Done. Let me know if there is anything else to do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.57% +0.08%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21460 +12603
- Misses 3593 8833 +5240
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.65% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | `88.67% <0.00%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `89.42% <0.00%> (ø)` | |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (ø)` | |
| [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (ø)` | |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian merged pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
suddjian merged pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624029921
Closed / reopened to restart stuck CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-646950596
Adding 0.37 label to this. @etr2460 is this ok to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-621161850
> @oashton I wonder if something went wrong in the rebase? This is showing 520 files changed with `+66,552 −33,417` rows changed.
@villebro , yes... I'm gonna fix it... I'll let you know as soon as a finish
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org