You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/23 11:20:10 UTC
[GitHub] [doris] starocean999 opened a new pull request, #12003: [fix](sort)the sort expr nullable info is wrong in some case
starocean999 opened a new pull request, #12003:
URL: https://github.com/apache/doris/pull/12003
# Proposed changes
Issue Number: close #xxx
## Problem summary
sort node expr may comes from the child outer join node, which is nullable if its a null-side of outer join. this pr does the same thing as https://github.com/apache/doris/pull/11700
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #12003: [fix](sort)the sort expr nullable info is wrong in some case
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #12003:
URL: https://github.com/apache/doris/pull/12003#discussion_r953316452
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SortInfo.java:
##########
@@ -271,6 +271,11 @@ public ExprSubstitutionMap createSortTupleInfo(
*/
public ExprSubstitutionMap createMaterializedOrderExprs(
TupleDescriptor sortTupleDesc, Analyzer analyzer) {
+ // the sort node exprs may come from the child outer join node
+ // we need change the slots to nullable from all outer join nullable side temporarily
+ // then the sort node expr would have correct nullable info
+ // after create the output tuple we need revert the change by call analyzer.changeSlotsToNotNullable(slots)
+ List<SlotDescriptor> slots = analyzer.changeSlotToNullableOfOuterJoinedTuples();
Review Comment:
nit: maybe we could wrap these two helper function into a closable resource and use try statement to do auto change back to avoid unpaired use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #12003: [fix](sort)the sort expr nullable info is wrong in some case
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #12003:
URL: https://github.com/apache/doris/pull/12003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12003: [fix](sort)the sort expr nullable info is wrong in some case
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12003:
URL: https://github.com/apache/doris/pull/12003#issuecomment-1225163827
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12003: [fix](sort)the sort expr nullable info is wrong in some case
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12003:
URL: https://github.com/apache/doris/pull/12003#issuecomment-1225163859
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org