You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/20 05:26:15 UTC
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1527: Fix: 1526
AlexStocks commented on a change in pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#discussion_r732424719
##########
File path: config/protocol_config.go
##########
@@ -27,9 +27,10 @@ import (
// ProtocolConfig is protocol configuration
type ProtocolConfig struct {
- Name string `required:"true" yaml:"name" json:"name,omitempty" property:"name"`
- Ip string `required:"true" yaml:"ip" json:"ip,omitempty" property:"ip"`
- Port string `required:"true" yaml:"port" json:"port,omitempty" property:"port"`
+ Name string `required:"true" yaml:"name" json:"name,omitempty" property:"name"`
+ Ip string `required:"true" yaml:"ip" json:"ip,omitempty" property:"ip"`
Review comment:
agree with u
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org