You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@creadur.apache.org by rd...@apache.org on 2011/07/16 19:42:41 UTC
svn commit: r1147466 - in /incubator/rat/eye/trunk:
apache-rat-eye-license-and-notice.py apache-rat-eye-meta-inf.py
org/apache/rat/eye/review.py
Author: rdonkin
Date: Sat Jul 16 17:42:40 2011
New Revision: 1147466
URL: http://svn.apache.org/viewvc?rev=1147466&view=rev
Log:
Add high level API to review module.
Modified:
incubator/rat/eye/trunk/apache-rat-eye-license-and-notice.py
incubator/rat/eye/trunk/apache-rat-eye-meta-inf.py
incubator/rat/eye/trunk/org/apache/rat/eye/review.py
Modified: incubator/rat/eye/trunk/apache-rat-eye-license-and-notice.py
URL: http://svn.apache.org/viewvc/incubator/rat/eye/trunk/apache-rat-eye-license-and-notice.py?rev=1147466&r1=1147465&r2=1147466&view=diff
==============================================================================
--- incubator/rat/eye/trunk/apache-rat-eye-license-and-notice.py (original)
+++ incubator/rat/eye/trunk/apache-rat-eye-license-and-notice.py Sat Jul 16 17:42:40 2011
@@ -30,9 +30,7 @@ from org.apache.rat.eye import style
def runBasicReport(base):
if os.path.exists(base):
- metaInfReviews = [review.MetaInfContainsLicenseAndNotice()]
- checks = [review.MetaInfReviewer(metaInfReviews)]
- engine.report(base, checks, style.simplePrint())
+ engine.report(base, review.checkLicenseAndNotice(), style.simplePrint())
sys.exit(0)
else:
sys.stderr.write("Base directory '{0}' not found\n".format(base))
Modified: incubator/rat/eye/trunk/apache-rat-eye-meta-inf.py
URL: http://svn.apache.org/viewvc/incubator/rat/eye/trunk/apache-rat-eye-meta-inf.py?rev=1147466&r1=1147465&r2=1147466&view=diff
==============================================================================
--- incubator/rat/eye/trunk/apache-rat-eye-meta-inf.py (original)
+++ incubator/rat/eye/trunk/apache-rat-eye-meta-inf.py Sat Jul 16 17:42:40 2011
@@ -30,9 +30,7 @@ from org.apache.rat.eye import review
def runBasicReport(base):
if os.path.exists(base):
- metaInfReviews = [review.MetaInfContents(), review.SimpleMetaInfView()]
- checks = [review.MetaInfReviewer(metaInfReviews)]
- engine.report(base, checks, style.simplePrint())
+ engine.report(base, review.presentMetaInf(), style.simplePrint())
sys.exit(0)
else:
sys.stderr.write("Base directory '{0}' not found\n".format(base))
Modified: incubator/rat/eye/trunk/org/apache/rat/eye/review.py
URL: http://svn.apache.org/viewvc/incubator/rat/eye/trunk/org/apache/rat/eye/review.py?rev=1147466&r1=1147465&r2=1147466&view=diff
==============================================================================
--- incubator/rat/eye/trunk/org/apache/rat/eye/review.py (original)
+++ incubator/rat/eye/trunk/org/apache/rat/eye/review.py Sat Jul 16 17:42:40 2011
@@ -97,6 +97,12 @@ class ManifestReportBuilder():
reviews.append(checkImplementationSpecification())
return [MetaInfReviewer([JarManifestReviewer([JarManifestHeaderNameReviewer(reviews)])])]
+def checkLicenseAndNotice():
+ return [MetaInfReviewer([MetaInfContainsLicenseAndNotice()])]
+
+def presentMetaInf():
+ return [MetaInfReviewer([MetaInfContents(), SimpleMetaInfView()])]
+
#
# Classes
#