You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/09 22:18:00 UTC
[GitHub] [netbeans] jlahoda opened a new pull request #2530: First attempt for Java getter/setter generator for the Java LSP server.
jlahoda opened a new pull request #2530:
URL: https://github.com/apache/netbeans/pull/2530
There are two (three) ways to run the generators:
-if a piece of code is selected, and contains fields, the proposal to add them is sent using code actions (a light bulb should appear)
-there is a new "Generate" sub-menu in the editor context menu in VS Code (note you need a fairly new VS Code to see it)
-via the Command Palette in VS Code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda merged pull request #2530: First attempt for Java getter/setter generator for the Java LSP server.
Posted by GitBox <gi...@apache.org>.
jlahoda merged pull request #2530:
URL: https://github.com/apache/netbeans/pull/2530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2530: First attempt for Java getter/setter generator for the Java LSP server.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2530:
URL: https://github.com/apache/netbeans/pull/2530#discussion_r543062912
##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java
##########
@@ -1129,7 +1171,115 @@ private JavaSource getSource(String fileUri) {
}
}
- private static List<TextEdit> modify2TextEdits(JavaSource js, Task<WorkingCopy> task) throws IOException {
+ public static Position createPosition(CompilationUnitTree cut, int offset) {
+ return createPosition(cut.getLineMap(), offset);
+ }
+
+ public static Position createPosition(LineMap lm, int offset) {
+ return new Position((int) lm.getLineNumber(offset) - 1,
+ (int) lm.getColumnNumber(offset) - 1);
+ }
+
+ public static Position createPosition(FileObject file, int offset) {
+ try {
+ EditorCookie ec = file.getLookup().lookup(EditorCookie.class);
+ StyledDocument doc = ec.openDocument();
+ int line = NbDocument.findLineNumber(doc, offset);
+ int column = NbDocument.findLineColumn(doc, offset);
+
+ return new Position(line, column);
+ } catch (IOException ex) {
+ throw new IllegalStateException(ex);
+ }
+ }
+
+ public static int getOffset(Document doc, Position pos) {
+ return LineDocumentUtils.getLineStartFromIndex((LineDocument) doc, pos.getLine()) + pos.getCharacter();
+ }
+
+ private static String toUri(FileObject file) {
+ if (FileUtil.isArchiveArtifact(file)) {
Review comment:
I've noticed this code during #2587 and asked why we aren't using `URLMapper.findURL(EXTERNAL)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2530: First attempt for Java getter/setter generator for the Java LSP server.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2530:
URL: https://github.com/apache/netbeans/pull/2530#issuecomment-725844068
CC @jisedlac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2530: First attempt for Java getter/setter generator for the Java LSP server.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2530:
URL: https://github.com/apache/netbeans/pull/2530#discussion_r543062912
##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java
##########
@@ -1129,7 +1171,115 @@ private JavaSource getSource(String fileUri) {
}
}
- private static List<TextEdit> modify2TextEdits(JavaSource js, Task<WorkingCopy> task) throws IOException {
+ public static Position createPosition(CompilationUnitTree cut, int offset) {
+ return createPosition(cut.getLineMap(), offset);
+ }
+
+ public static Position createPosition(LineMap lm, int offset) {
+ return new Position((int) lm.getLineNumber(offset) - 1,
+ (int) lm.getColumnNumber(offset) - 1);
+ }
+
+ public static Position createPosition(FileObject file, int offset) {
+ try {
+ EditorCookie ec = file.getLookup().lookup(EditorCookie.class);
+ StyledDocument doc = ec.openDocument();
+ int line = NbDocument.findLineNumber(doc, offset);
+ int column = NbDocument.findLineColumn(doc, offset);
+
+ return new Position(line, column);
+ } catch (IOException ex) {
+ throw new IllegalStateException(ex);
+ }
+ }
+
+ public static int getOffset(Document doc, Position pos) {
+ return LineDocumentUtils.getLineStartFromIndex((LineDocument) doc, pos.getLine()) + pos.getCharacter();
+ }
+
+ private static String toUri(FileObject file) {
+ if (FileUtil.isArchiveArtifact(file)) {
Review comment:
I've noticed this code during #2587 and asked why we aren't using `URLMapper.findURL(EXTERNAL)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2530: First attempt for Java getter/setter generator for the Java LSP server.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2530:
URL: https://github.com/apache/netbeans/pull/2530#discussion_r521845901
##########
File path: java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
##########
@@ -1134,6 +1140,93 @@ public void logMessage(MessageParams arg0) {
}
}
+ public void testCodeActionGetterSetting() throws Exception {
Review comment:
Great, there is a test!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists