You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:42:11 UTC

[GitHub] [flink] rkhachatryan commented on a change in pull request #13866: [FLINK-19907][network] Recover channel state before initializing operators chain

rkhachatryan commented on a change in pull request #13866:
URL: https://github.com/apache/flink/pull/13866#discussion_r515830326



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -502,9 +502,9 @@ protected void beforeInvoke() throws Exception {
 			// both the following operations are protected by the lock

Review comment:
       Done)

##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -502,9 +502,9 @@ protected void beforeInvoke() throws Exception {
 			// both the following operations are protected by the lock
 			// so that we avoid race conditions in the case that initializeState()
 			// registers a timer, that fires before the open() is called.
-			operatorChain.initializeStateAndOpenOperators(createStreamTaskStateInitializer());

Review comment:
       I don't think there are any issues with that, operators are kind of level above on ResultPartitions (and therefore should be initialized later).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org