You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Donghui Xu (Code Review)" <ge...@cloudera.org> on 2017/06/15 09:26:36 UTC
[Impala-ASF-CR] IMPALA-5514: Add the joint judgment of ldap password cmd and ldap
Donghui Xu has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7188
Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap
......................................................................
IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap
When only with ldap_password_cmd option, impala-shell runs successfully.
I solved this problem by adding the joint judgment of ldap_password_cmd and ldap,
that is, ldap_password_cmd option will only appear if ldap option appears.
Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
---
M shell/impala_shell.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7188/1
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
[Impala-ASF-CR] IMPALA-5514: Add the joint judgment of ldap password cmd and ldap
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap
......................................................................
Patch Set 2:
Can anyone review this issue please? Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5514: Add the joint judgment of ldap password cmd and ldap
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#2).
Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap
......................................................................
IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap
When only with ldap_password_cmd option, impala-shell runs successfully.
I solved this problem by adding the joint judgment of ldap_password_cmd
and ldap, that is, ldap_password_cmd option will only take effect if
ldap option presents.
Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
---
M shell/impala_shell.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7188/2
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/843/
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#3).
Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
......................................................................
IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
When only with ldap_password_cmd option, impala-shell runs successfully.
I solved this problem by throwing an error when --ldap_password_cmd is
used without LDAP auth, that is, ldap_password_cmd option will only
take effect if ldap option presents.
Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
---
M shell/impala_shell.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7188/3
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
I can run the pre-commit job once you fix the longline. +2'ing since the patch is trivial.
http://gerrit.cloudera.org:8080/#/c/7188/3/shell/impala_shell.py
File shell/impala_shell.py:
Line 1333: print_to_stderr("Option --ldap_password_cmd requires using LDAP authentication mechanism (-l)")
long line
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
......................................................................
Patch Set 3:
(3 comments)
Thank you for the suggestion. I have modified the code.
http://gerrit.cloudera.org:8080/#/c/7188/2//COMMIT_MSG
Commit Message:
PS2, Line 7: Throw an error when --ldap_password_cmd is used with
> Sorry for nitpicking, I don't think judgement is the right word here. How a
Done
PS2, Line 11:
> nit: Please remove trailing spaces (here and below)
Done
http://gerrit.cloudera.org:8080/#/c/7188/2/shell/impala_shell.py
File shell/impala_shell.py:
PS2, Line 1333: Option --ldap_password_cmd requires using LDAP authentication m
> IMO something like "Option --ldap_password_cmd requires using LDAP authenti
Done
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
......................................................................
IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
When only with ldap_password_cmd option, impala-shell runs successfully.
I solved this problem by throwing an error when --ldap_password_cmd is
used without LDAP auth, that is, ldap_password_cmd option will only
take effect if ldap option presents.
Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Reviewed-on: http://gerrit.cloudera.org:8080/7188
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M shell/impala_shell.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Bharath Vissapragada: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5514: Add the joint judgment of ldap password cmd and ldap
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap
......................................................................
Patch Set 2:
(3 comments)
Thanks for raising the jira and submitting a quick fix. The fix looks good mostly apart from a few nits. Mind fixing them?
http://gerrit.cloudera.org:8080/#/c/7188/2//COMMIT_MSG
Commit Message:
PS2, Line 7: Add the joint judgment of ldap_password_cmd and ldap
Sorry for nitpicking, I don't think judgement is the right word here. How about, "Throw an error when --ldap_password_cmd is used without LDAP auth" ? (Also please update the description below accordingly).
PS2, Line 11:
nit: Please remove trailing spaces (here and below)
http://gerrit.cloudera.org:8080/#/c/7188/2/shell/impala_shell.py
File shell/impala_shell.py:
PS2, Line 1333: Must use LDAP authentication while retrieving the LDAP password
IMO something like "Option --ldap_password_cmd requires using LDAP authentication mechanism (-l)" gives a more detailed description to the end user as to what the actual problem is. What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7188
to look at the new patch set (#4).
Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
......................................................................
IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth
When only with ldap_password_cmd option, impala-shell runs successfully.
I solved this problem by throwing an error when --ldap_password_cmd is
used without LDAP auth, that is, ldap_password_cmd option will only
take effect if ldap option presents.
Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
---
M shell/impala_shell.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7188/4
--
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>