You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/20 12:57:19 UTC

Re: Review Request 45270: Added spec protobuf for DockerVolume.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 20, 2016, 10:57 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Summary (updated)
-----------------

Added spec protobuf for DockerVolume.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Added spec protobuf for DockerVolume.
The DockerVolume was used to check point the mount
point for each container when recover.


Diffs (updated)
-----

  src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed 
  src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
  src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobuf for DockerVolume.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129751
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On April 20, 2016, 10:57 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 10:57 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobuf for DockerVolume.
> The DockerVolume was used to check point the mount
> point for each container when recover.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobuf for DockerVolume.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129753
-----------------------------------------------------------




src/Makefile.am (line 837)
<https://reviews.apache.org/r/45270/#comment193291>

    Why remove paths.hpp??
    
    Please be careful and do a make distcheck when submitting a patch.


- Jie Yu


On April 20, 2016, 10:57 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 10:57 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobuf for DockerVolume.
> The DockerVolume was used to check point the mount
> point for each container when recover.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobuf for DockerVolume.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 20, 2016, 5:39 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Added spec protobuf for DockerVolume.
The DockerVolume was used to check point the mount
point for each container when recover.


Diffs (updated)
-----

  src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed 
  src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
  src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu