You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by sebb <se...@gmail.com> on 2017/02/26 21:43:22 UTC
Re: svn commit: r1784457 - in /jmeter/trunk/bin/testfiles:
TEST_HTTP.csv TEST_HTTP.jmx TEST_HTTP.xml
On 26 February 2017 at 15:57, <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Sun Feb 26 15:57:25 2017
> New Revision: 1784457
>
> URL: http://svn.apache.org/viewvc?rev=1784457&view=rev
> Log:
> Add Non Regression tests on HTTP Request for:
> Bug 60682
> Bug 60575
>
> Added:
> jmeter/trunk/bin/testfiles/TEST_HTTP.csv
> jmeter/trunk/bin/testfiles/TEST_HTTP.jmx (with props)
> jmeter/trunk/bin/testfiles/TEST_HTTP.xml (with props)
The test name is far too generic.
It would be better to name it after the Bugs it tests.
Even better would be one test script per bug.
Re: svn commit: r1784457 - in /jmeter/trunk/bin/testfiles:
TEST_HTTP.csv TEST_HTTP.jmx TEST_HTTP.xml
Posted by sebb <se...@gmail.com>.
On 26 February 2017 at 21:47, Philippe Mouawad
<ph...@gmail.com> wrote:
> On Sun, Feb 26, 2017 at 10:43 PM, sebb <se...@gmail.com> wrote:
>
>> On 26 February 2017 at 15:57, <pm...@apache.org> wrote:
>> > Author: pmouawad
>> > Date: Sun Feb 26 15:57:25 2017
>> > New Revision: 1784457
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1784457&view=rev
>> > Log:
>> > Add Non Regression tests on HTTP Request for:
>> > Bug 60682
>> > Bug 60575
>> >
>> > Added:
>> > jmeter/trunk/bin/testfiles/TEST_HTTP.csv
>> > jmeter/trunk/bin/testfiles/TEST_HTTP.jmx (with props)
>> > jmeter/trunk/bin/testfiles/TEST_HTTP.xml (with props)
>>
>> The test name is far too generic.
>>
> If you have a better name go ahead
> Maybe TestHttpRequest
>
>>
>> It would be better to name it after the Bugs it tests.
>> Even better would be one test script per bug.
>>
> I don't share this vision.
> Using Bug ID is too restrictive and if we migrate one day to JIRA this will
> be a problem.
No, it won't be a problem. JIRA has a field for the original Bugzilla id.
In the meantime it's not at all obvious what TEST_HTTP is used for.
> I just added bug id in test plan.
That is not easy to read.
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: svn commit: r1784457 - in /jmeter/trunk/bin/testfiles:
TEST_HTTP.csv TEST_HTTP.jmx TEST_HTTP.xml
Posted by Philippe Mouawad <ph...@gmail.com>.
On Sun, Feb 26, 2017 at 10:43 PM, sebb <se...@gmail.com> wrote:
> On 26 February 2017 at 15:57, <pm...@apache.org> wrote:
> > Author: pmouawad
> > Date: Sun Feb 26 15:57:25 2017
> > New Revision: 1784457
> >
> > URL: http://svn.apache.org/viewvc?rev=1784457&view=rev
> > Log:
> > Add Non Regression tests on HTTP Request for:
> > Bug 60682
> > Bug 60575
> >
> > Added:
> > jmeter/trunk/bin/testfiles/TEST_HTTP.csv
> > jmeter/trunk/bin/testfiles/TEST_HTTP.jmx (with props)
> > jmeter/trunk/bin/testfiles/TEST_HTTP.xml (with props)
>
> The test name is far too generic.
>
If you have a better name go ahead
Maybe TestHttpRequest
>
> It would be better to name it after the Bugs it tests.
> Even better would be one test script per bug.
>
I don't share this vision.
Using Bug ID is too restrictive and if we migrate one day to JIRA this will
be a problem.
I just added bug id in test plan.
--
Cordialement.
Philippe Mouawad.