[jira] [Resolved] (PDFBOX-1833) BaseParser tidy up

["Tilman Hausherr (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PDFBOX-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tilman Hausherr resolved PDFBOX-1833.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.8
         Assignee: Tilman Hausherr

I've committed a slightly modified version of your patch which left out pure formatting changes. This can still be done in a separate step. I've recently avoided reformatting because it then takes longer to see changes when going through history, and the parser is a tricky part of PDFBox.

> BaseParser tidy up
> ------------------
>
>                 Key: PDFBOX-1833
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1833
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Parsing
>    Affects Versions: 1.8.7, 1.8.8, 2.0.0
>            Reporter: Jens Kapitza
>            Assignee: Tilman Hausherr
>            Priority: Minor
>             Fix For: 1.8.8, 2.0.0
>
>         Attachments: baseparser.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Tidy up logic (should not change the parsing result)
> Character.isWhitespace(c) is the only point wich may have site effects (but i assume there is no File-Seperator in parseCOSHexString)
> so this should pass as it passes befor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)