You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/03/27 08:27:52 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #7959:
[FLINK-11876] Introduce new InputSelectable,
BoundedOneInput and BoundedMultiInput interfaces
pnowojski commented on a change in pull request #7959: [FLINK-11876] Introduce new InputSelectable, BoundedOneInput and BoundedMultiInput interfaces
URL: https://github.com/apache/flink/pull/7959#discussion_r269445651
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InputSelection.java
##########
@@ -79,15 +79,15 @@ public String toString() {
* Selects an input identified by the given {@code inputId}.
*
* @param inputId
- * the input id numbered starting from 1 to 63, and `1` indicates the first input.
+ * the input id numbered starting from 1 to 64, and `1` indicates the first input.
* Specially, `-1` indicates all inputs.
* @return
*/
public InputSelectionBuilder select(long inputId) {
if (inputId > 0 && inputId <= 64){
- inputMask |= 1 << (inputId - 1);
- } else if (inputId == -1) {
- inputMask = -1;
+ inputMask |= 1L << (inputId - 1);
Review comment:
Please add a test that will cover for the int/long bug fixed by `fix bug in the InputSelectionBuilder class`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services