[jira] [Closed] (FLINK-14306) flink-python build fails with No module named pkg_resources

["Hequn Cheng (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hequn Cheng closed FLINK-14306.
-------------------------------
    Resolution: Fixed

> flink-python build fails with No module named pkg_resources
> -----------------------------------------------------------
>
>                 Key: FLINK-14306
>                 URL: https://issues.apache.org/jira/browse/FLINK-14306
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Python, Build System
>    Affects Versions: 1.10.0
>            Reporter: Piotr Nowojski
>            Assignee: Dian Fu
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> [Benchmark builds|http://codespeed.dak8s.net:8080/job/flink-master-benchmarks/4576/console] started to fail with
> {noformat}
> [INFO] Adding generated sources (java): /home/jenkins/workspace/flink-master-benchmarks/flink/flink-python/target/generated-sources
> [INFO] 
> [INFO] --- exec-maven-plugin:1.5.0:exec (Protos Generation) @ flink-python_2.11 ---
> Traceback (most recent call last):
>   File "/home/jenkins/workspace/flink-master-benchmarks/flink/flink-python/pyflink/gen_protos.py", line 33, in <module>
>     import pkg_resources
> ImportError: No module named pkg_resources
> [ERROR] Command execution failed.
> (...)
> [INFO] flink-state-processor-api .......................... SUCCESS [  0.299 s]
> [INFO] flink-python ....................................... FAILURE [  0.434 s]
> [INFO] flink-scala-shell .................................. SKIPPED
> {noformat}
> because of this ticket: https://issues.apache.org/jira/browse/FLINK-14018
> I think I can solve the benchmark builds failing quite easily by installing {{setuptools}} python package, so this ticket is not about this, but about deciding how should we treat such kind of external dependencies. I don't see this dependency being mentioned anywhere in the documentation ([for example here|https://ci.apache.org/projects/flink/flink-docs-stable/flinkDev/building.html]).
> Probably at the very least those external dependencies should be documented, but also I fear about such kind of manual steps to do before building the Flink can become a problem if grow out of control. Some questions:
> # Do we really need this dependency?
> # Could this dependency be resolve automatically? By installing into a local python virtual environment?
> # Should we document those dependencies somewhere?
> # Maybe we should not build flink-python by default?
> # Maybe we should add a pre-build script for flink-python to verify the dependencies and to throw an easy to understand error with hint how to fix it?
> CC [~hequn] [~dian.fu] [~trohrmann] [~jincheng]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)