You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2026/02/09 09:45:04 UTC
[PR] [Bug](rec-cte) reset _require_bucket_distribution in PipelineFragmentContext::rebuild [doris]
BiteTheDDDDt opened a new pull request, #60618:
URL: https://github.com/apache/doris/pull/60618
### What problem does this PR solve?
reset _require_bucket_distribution in PipelineFragmentContext::rebuild
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](rec-cte) reset _require_bucket_distribution in PipelineFragmentContext::rebuild [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #60618:
URL: https://github.com/apache/doris/pull/60618#discussion_r2781703327
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -2089,6 +2089,8 @@ Status PipelineFragmentContext::set_to_rerun() {
Status PipelineFragmentContext::rebuild(ThreadPool* thread_pool) {
_submitted = false;
_is_fragment_instance_closed = false;
+ // _require_bucket_distribution may be set to true to affect the building of pipeline with local shuffle
+ _require_bucket_distribution = false;
return _build_and_prepare_full_pipeline(thread_pool);
Review Comment:
This change fixes state carried across `rebuild()`, but there doesn’t appear to be any unit test coverage for the rerun/rebuild path (e.g., a rec-CTE round triggering `wait/release/rebuild/submit`). Consider adding a BE pipeline unit test that exercises at least two rebuild cycles and asserts the pipeline build outcome isn’t affected by stale `_require_bucket_distribution` from the prior build (e.g., local shuffle/bucket distribution decisions differ between rounds).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](rec-cte) reset _require_bucket_distribution in PipelineFragmentContext::rebuild [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #60618:
URL: https://github.com/apache/doris/pull/60618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](rec-cte) reset _require_bucket_distribution in PipelineFragmentContext::rebuild [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #60618:
URL: https://github.com/apache/doris/pull/60618#issuecomment-3870614043
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](rec-cte) reset _require_bucket_distribution in PipelineFragmentContext::rebuild [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60618:
URL: https://github.com/apache/doris/pull/60618#issuecomment-3871095319
# BE UT Coverage Report
Increment line coverage `0.00% (0/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/88e8eb0ff4e7e8a9d70def6078a7bcf7dc64076a_88e8eb0ff4e7e8a9d70def6078a7bcf7dc64076a/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/88e8eb0ff4e7e8a9d70def6078a7bcf7dc64076a_88e8eb0ff4e7e8a9d70def6078a7bcf7dc64076a/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.72% (19445/36882) |
| Line Coverage | 36.21% (181010/499901) |
| Region Coverage | 32.60% (140549/431169) |
| Branch Coverage | 33.62% (60876/181049) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](rec-cte) reset _require_bucket_distribution in PipelineFragmentContext::rebuild [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60618:
URL: https://github.com/apache/doris/pull/60618#issuecomment-3871474925
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60618_88e8eb0ff4e7e8a9d70def6078a7bcf7dc64076a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60618_88e8eb0ff4e7e8a9d70def6078a7bcf7dc64076a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.37% (26515/36138) |
| Line Coverage | 56.46% (281527/498663) |
| Region Coverage | 54.17% (235938/435551) |
| Branch Coverage | 55.74% (101318/181753) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](rec-cte) reset _require_bucket_distribution in PipelineFragmentContext::rebuild [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #60618:
URL: https://github.com/apache/doris/pull/60618#discussion_r2781758868
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -2089,6 +2089,8 @@ Status PipelineFragmentContext::set_to_rerun() {
Status PipelineFragmentContext::rebuild(ThreadPool* thread_pool) {
_submitted = false;
_is_fragment_instance_closed = false;
+ // _require_bucket_distribution may be set to true to affect the building of pipeline with local shuffle
+ _require_bucket_distribution = false;
return _build_and_prepare_full_pipeline(thread_pool);
Review Comment:
@copilot open a new pull request to apply changes based on [this feedback](https://github.com/apache/doris/pull/60618#discussion_r2781703327)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](rec-cte) reset _require_bucket_distribution in PipelineFragmentContext::rebuild [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60618:
URL: https://github.com/apache/doris/pull/60618#issuecomment-3874874785
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](rec-cte) reset _require_bucket_distribution in PipelineFragmentContext::rebuild [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60618:
URL: https://github.com/apache/doris/pull/60618#issuecomment-3874874861
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org