[jira] [Updated] (HBASE-14628) Save object creation for scanning with FAST_DIFF encoding

["Lars Hofhansl (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-14628:
----------------------------------
    Attachment: 14628-0.98.txt

Found the problem. Here's a 0.98 patch.
The actual macro win is 5% (not the 10% I promised above).

Readability is roughly equal, I feel. Have a look and let me whether it's worth the change.

> Save object creation for scanning with FAST_DIFF encoding
> ---------------------------------------------------------
>
>                 Key: HBASE-14628
>                 URL: https://issues.apache.org/jira/browse/HBASE-14628
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>         Attachments: 14628-0.98.txt
>
>
> I noticed that (at least in 0.98 - master is entirely different) we create ByteBuffer just to create a byte[], which is then used to create a KeyValue.
> We can save the creation of the ByteBuffer and hence save allocating an extra object for each KV we find by creating the byte[] directly.
> In a Phoenix count\(*) query that saved from 10% of runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)