You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Robert Jordan (JIRA)" <ji...@apache.org> on 2010/05/01 21:13:56 UTC

[jira] Created: (LUCENENET-363) Compatibility fix for Mono

Compatibility fix for Mono
--------------------------

                 Key: LUCENENET-363
                 URL: https://issues.apache.org/jira/browse/LUCENENET-363
             Project: Lucene.Net
          Issue Type: Bug
         Environment: Linux/Mono 2.6.x
            Reporter: Robert Jordan
         Attachments: TestIndexReader.diff

TestIndexReader.TestTermVectors() is enumerating over a generic SortedDictionary with a non-generic IEnumerator.

MS.NET is returning a KeyValuePair  while Mono is (correctly, IMHO) returning a DictionaryEntry, because the user was actually requesting a non-generic enumerator.

The fix is kinda trivial: use a generic IEnumerator. The code is much readable this way, too. See the attached patch.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (LUCENENET-363) Compatibility fix for Mono

Posted by "Digy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Digy resolved LUCENENET-363.
----------------------------

      Assignee: Digy
    Resolution: Fixed

Thanks Robert,
I committed the patch. 
In fact, that part of this test is redundant  for .NET.  "entry" can never be null.( In Java, "Set" allows null keys).

DIGY.

> Compatibility fix for Mono
> --------------------------
>
>                 Key: LUCENENET-363
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-363
>             Project: Lucene.Net
>          Issue Type: Bug
>         Environment: Linux/Mono 2.6.x
>            Reporter: Robert Jordan
>            Assignee: Digy
>         Attachments: TestIndexReader.diff
>
>
> TestIndexReader.TestTermVectors() is enumerating over a generic SortedDictionary with a non-generic IEnumerator.
> MS.NET is returning a KeyValuePair  while Mono is (correctly, IMHO) returning a DictionaryEntry, because the user was actually requesting a non-generic enumerator.
> The fix is kinda trivial: use a generic IEnumerator. The code is much readable this way, too. See the attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (LUCENENET-363) Compatibility fix for Mono

Posted by "Robert Jordan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Jordan updated LUCENENET-363:
------------------------------------

    Attachment: TestIndexReader.diff

> Compatibility fix for Mono
> --------------------------
>
>                 Key: LUCENENET-363
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-363
>             Project: Lucene.Net
>          Issue Type: Bug
>         Environment: Linux/Mono 2.6.x
>            Reporter: Robert Jordan
>         Attachments: TestIndexReader.diff
>
>
> TestIndexReader.TestTermVectors() is enumerating over a generic SortedDictionary with a non-generic IEnumerator.
> MS.NET is returning a KeyValuePair  while Mono is (correctly, IMHO) returning a DictionaryEntry, because the user was actually requesting a non-generic enumerator.
> The fix is kinda trivial: use a generic IEnumerator. The code is much readable this way, too. See the attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.