You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "whaon (via GitHub)" <gi...@apache.org> on 2025/09/05 09:04:54 UTC
[PR] bugfix: adjust the order of org.apache.seata.saga.rm.SagaResourceManage [incubator-seata]
whaon opened a new pull request, #7622:
URL: https://github.com/apache/incubator-seata/pull/7622
…er to the last,so it can override the io.seata.saga.rm.SagaResourceManager
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
adjust the order of org.apache.seata.saga.rm.SagaResourceManager to the last, so it can override the io.seata.saga.rm.SagaResourceManager
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fix #7108
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: adjust the order of org.apache.seata.saga.rm.SagaResourceManage [incubator-seata]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #7622:
URL: https://github.com/apache/incubator-seata/pull/7622#issuecomment-3270314930
Please fix failing test
```
Error: SPITest.testRmSPIOrder:39 expected: <io.seata.saga.rm.SagaResourceManager> but was: <org.apache.seata.saga.rm.SagaResourceManager>
```
- https://github.com/apache/incubator-seata/actions/runs/17488786085/job/49674251235?pr=7622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: adjust the order of org.apache.seata.saga.rm.SagaResourceManage [incubator-seata]
Posted by "xjlgod (via GitHub)" <gi...@apache.org>.
xjlgod merged PR #7622:
URL: https://github.com/apache/incubator-seata/pull/7622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: adjust the order of org.apache.seata.saga.rm.SagaResourceManage [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7622:
URL: https://github.com/apache/incubator-seata/pull/7622#issuecomment-3279475698
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7622?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 61.05%. Comparing base ([`d859fef`](https://app.codecov.io/gh/apache/incubator-seata/commit/d859fef4eb8be9e814e69de63538cbd0bed8165f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2a2eb49`](https://app.codecov.io/gh/apache/incubator-seata/commit/2a2eb4930668fb1d2a82ee5ad1c5bafe84a42648?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on 2.x.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7622 +/- ##
============================================
+ Coverage 61.02% 61.05% +0.02%
Complexity 666 666
============================================
Files 1316 1316
Lines 49800 49804 +4
Branches 5855 5855
============================================
+ Hits 30389 30406 +17
+ Misses 16706 16692 -14
- Partials 2705 2706 +1
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7622?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/seata/saga/rm/SagaResourceManager.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7622?src=pr&el=tree&filepath=saga%2Fseata-saga-rm%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fsaga%2Frm%2FSagaResourceManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXJtL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9zYWdhL3JtL1NhZ2FSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `8.16% <ø> (ø)` | |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7622/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7622?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: adjust the order of org.apache.seata.saga.rm.SagaResourceManage [incubator-seata]
Posted by "whaon (via GitHub)" <gi...@apache.org>.
whaon commented on PR #7622:
URL: https://github.com/apache/incubator-seata/pull/7622#issuecomment-3279480270
Finished @YongGoose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org