Re: [PR] Do not use direct IP allocation for isolated networks with SpecifyIpRanges [cloudstack]

["Damans227 (via GitHub)" <gi...@apache.org>]

Damans227 commented on code in PR #14087:
URL: https://github.com/apache/cloudstack/pull/14087#discussion_r4295810837


##########
server/src/main/java/com/cloud/network/guru/GuestNetworkGuru.java:
##########
@@ -442,7 +442,7 @@ public NicProfile allocate(final Network network, NicProfile nic, final VirtualM
             nic.setIPv4Gateway(network.getGateway());
 
             String guestIp = null;
-            if (network.getSpecifyIpRanges()) {
+            if (GuestType.Shared.equals(network.getGuestType()) && network.getSpecifyIpRanges()) {

Review Comment:
   is it expected that vms now get any ip in the cidr and ignore the start and end ip set on the network? in your test the new vm got .9, outside the .10 to .13 range



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org