[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #449: [Feature] shuffle server report storage capability

[GitBox <gi...@apache.org>]

zuston commented on code in PR #449:
URL: https://github.com/apache/incubator-uniffle/pull/449#discussion_r1060357332


##########
proto/src/main/proto/Rss.proto:
##########
@@ -239,6 +239,7 @@ message ShuffleServerHeartBeatRequest {
   int32 eventNumInFlush = 5;
   repeated string tags = 6;
   google.protobuf.BoolValue isHealthy = 7;
+  map<string, LocalStorageInfo> localStorages = 21; // mount point to local storage info mapping.

Review Comment:
   why not directly using `repeated LocalStorageInfo localStorages`



##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -336,6 +336,12 @@ public class ShuffleServerConf extends RssBaseConf {
       .withDescription("Threshold when flushing shuffle data to persistent storage, recommend value would be 256K, "
           + "512K, or even 1M");
 
+  public static final ConfigOption<String> STORAGE_TYPE_PROVIDER_ENV_KEY = ConfigOptions

Review Comment:
   Is this an internal config entry? If yes, could you mark it, rename from  `STORAGE_TYPE_PROVIDER_ENV_KEY` to `__INTERNAL_STORAGE_TYPE_PROVIDER_ENV_KEY` ? WDYT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org