[GitHub] [arrow] wgtmac commented on a diff in pull request #34632: GH-34536: [Parquet][C++] Overwrite default config for DeltaBitPackEncoder

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #34632:
URL: https://github.com/apache/arrow/pull/34632#discussion_r1141643429


##########
cpp/src/parquet/encoding.cc:
##########
@@ -2100,9 +2100,12 @@ class DictByteArrayDecoderImpl : public DictDecoderImpl<ByteArrayType>,
 
 template <typename DType>
 class DeltaBitPackEncoder : public EncoderImpl, virtual public TypedEncoder<DType> {
+  static_assert(std::is_same_v<int32_t, typename DType::c_type> ||
+                std::is_same_v<int64_t, typename DType::c_type>);
   // Maximum possible header size
   static constexpr uint32_t kMaxPageHeaderWriterSize = 32;

Review Comment:
   It would be better to make them configurable. Either at writer level (via `WriterProperties`) or column level (via `ColumnProperties`). Otherwise user does not have a way to tune performance or mitigate regression at the run time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org