You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/07/04 18:32:47 UTC

[GitHub] [arrow] mapleFU commented on pull request #36463: GH-36446: [C++] ConcatenateImpl fixing style

mapleFU commented on PR #36463:
URL: https://github.com/apache/arrow/pull/36463#issuecomment-1620610739

   We can also uses:
   
   ```
   ConcatenateImpl(ArrayDataVector in, MemoryPool* pool)
   ```
   
   and call move when calling to `ConcatenateImpl::ConcatenateImpl`, but I guess copying `shared_ptr` is not bottleneck here. If reviewer want, I'll do it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org