You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andishgar (via GitHub)" <gi...@apache.org> on 2025/05/05 09:51:48 UTC
[PR] GH-46177: [C++][Compute] Enable MemAllocation::PREALLOCATE for DenseUnion, SparseUnion, ListView, LargeListView, BinaryView, StringView [arrow]
andishgar opened a new pull request, #46317:
URL: https://github.com/apache/arrow/pull/46317
### Rationale for this change
As mentioned [here](https://github.com/apache/arrow/issues/46177#issuecomment-2835628516), there is no preallocation strategy for the following types in compute API: ListView, LargeListView, BinaryView, StringView, DenseUnion, SparseUnion
### What changes are included in this PR?
Enable `MemAllocation::PREALLOCATE` for the types mentioned above.
### Are these changes tested?
I run the relevant unit tests.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46177: [C++][Compute] Enable MemAllocation::PREALLOCATE for DenseUnion, SparseUnion, ListView, LargeListView, BinaryView, StringView [arrow]
Posted by "andishgar (via GitHub)" <gi...@apache.org>.
andishgar commented on PR #46317:
URL: https://github.com/apache/arrow/pull/46317#issuecomment-2888559973
@pitrou Thanks for sharing your thoughts. Just a quick note: I already have another [pull request](https://github.com/apache/arrow/pull/46230) that involves correcting the allocation strategy. This pull request needs to be resolved first so I can address the other one, as I explained [here](https://github.com/apache/arrow/issues/46177#issuecomment-2842070242).
I’d suggest creating a separate issue to track and fix the kernel allocation problems.
What do you think? Would it be okay if I open a new issue for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46177: [C++][Compute] Enable MemAllocation::PREALLOCATE for DenseUnion, SparseUnion, ListView, LargeListView, BinaryView, StringView [arrow]
Posted by "andishgar (via GitHub)" <gi...@apache.org>.
andishgar commented on PR #46317:
URL: https://github.com/apache/arrow/pull/46317#issuecomment-2853693478
I understand that I should revise the following comments, but I’d prefer someone else to do it, as I’m not fluent in English.
https://github.com/apache/arrow/blob/426d890df75b9f84e642ebaae9662aa750536aa6/cpp/src/arrow/compute/kernel.h#L453-L462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46177: [C++][Compute] Enable MemAllocation::PREALLOCATE for DenseUnion, SparseUnion, ListView, LargeListView, BinaryView, StringView [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46317:
URL: https://github.com/apache/arrow/pull/46317#issuecomment-4477586344
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46177: [C++][Compute] Enable MemAllocation::PREALLOCATE for DenseUnion, SparseUnion, ListView, LargeListView, BinaryView, StringView [arrow]
Posted by "andishgar (via GitHub)" <gi...@apache.org>.
andishgar commented on PR #46317:
URL: https://github.com/apache/arrow/pull/46317#issuecomment-2876654627
@pitrou Could you review my pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46177: [C++][Compute] Enable MemAllocation::PREALLOCATE for DenseUnion, SparseUnion, ListView, LargeListView, BinaryView, StringView [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #46317: GH-46177: [C++][Compute] Enable MemAllocation::PREALLOCATE for DenseUnion, SparseUnion, ListView, LargeListView, BinaryView, StringView
URL: https://github.com/apache/arrow/pull/46317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org