You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2014/05/14 22:34:36 UTC
[jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Depends on https://github.com/jclouds/jclouds/pull/368
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack add-swift-timeout-test
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/99
-- Commit Summary --
* Adds a test making sure swift calls will timeout with the right settings.
-- File Changes --
M openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ObjectApiMockTest.java (35)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/99.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/99.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
Hmm needs to be investigated some more.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43134879
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
Closed #99.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#event-121552573
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
Reopened #99.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#event-121539637
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
Closed #99.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#event-121277678
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #241](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/241/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43234738
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #238](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/238/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43158169
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #236](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/236/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43136439
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #239](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/239/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43231922
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1135](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1135/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43157801
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1131](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1131/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43135636
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
Closed #99.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#event-121539627
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #234](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/234/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43135281
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43235534
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
Reopened #99.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#event-121204896
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1132](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1132/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43136594
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
> + MockWebServer server = mockOpenStackServer();
> + server.enqueue(addCommonHeaders(new MockResponse().setBody(stringFromResource("/access.json"))));
> + // Typically we would enqueue a response for the put. However, in this case, test the timeout by not providing one.
> +
> + try {
> + Properties overrides = new Properties();
> +
> + overrides.setProperty(PROPERTY_SO_TIMEOUT, 5000 + ""); // This time-outs the connection
> + overrides.setProperty(PROPERTY_MAX_RETRIES, 0 + ""); // 0 retries == 1 try. Semantics.
> + overrides.setProperty(PROPERTY_RETRY_DELAY_START, 0 + ""); // exponential backoff already working for this call. This is the delay BETWEEN attempts.
> +
> + final SwiftApi api = api(server.getUrl("/").toString(), "openstack-swift", overrides);
> +
> + String result = api.objectApiInRegionForContainer("DFW", "myContainer").replace("myObject", newStringPayload("swifty"), metadata);
> +
> + fail("testReplaceTimeout test should have failed with an ExecutionException.");
Sweet, thanks @demobox. Will fix.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99/files#r12694885
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Andrew Phillips <no...@github.com>.
Thanks, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43562582
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1130](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1130/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43134708
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
Will rebase and merge after tests
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43229648
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1143](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1143/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43234131
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Zack Shoylev <no...@github.com>.
Closed #99.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#event-121204889
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #240](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/240/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43233549
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1142](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1142/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43232917
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Andrew Phillips <no...@github.com>.
> + MockWebServer server = mockOpenStackServer();
> + server.enqueue(addCommonHeaders(new MockResponse().setBody(stringFromResource("/access.json"))));
> + // Typically we would enqueue a response for the put. However, in this case, test the timeout by not providing one.
> +
> + try {
> + Properties overrides = new Properties();
> +
> + overrides.setProperty(PROPERTY_SO_TIMEOUT, 5000 + ""); // This time-outs the connection
> + overrides.setProperty(PROPERTY_MAX_RETRIES, 0 + ""); // 0 retries == 1 try. Semantics.
> + overrides.setProperty(PROPERTY_RETRY_DELAY_START, 0 + ""); // exponential backoff already working for this call. This is the delay BETWEEN attempts.
> +
> + final SwiftApi api = api(server.getUrl("/").toString(), "openstack-swift", overrides);
> +
> + String result = api.objectApiInRegionForContainer("DFW", "myContainer").replace("myObject", newStringPayload("swifty"), metadata);
> +
> + fail("testReplaceTimeout test should have failed with an ExecutionException.");
"with an HttpResponseException"?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99/files#r12689537
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by Andrew Phillips <no...@github.com>.
Guess we're waiting until the other PR is merged to bump this again and see the test succeed. But the code change looks good to me.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43211194
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1141](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1141/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43229633
Re: [jclouds-labs-openstack] Adds a test making sure swift calls will
timeout with the right settings (#99)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #235](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/235/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/99#issuecomment-43135273