You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "leizhiyuan (via GitHub)" <gi...@apache.org> on 2024/08/14 11:21:46 UTC
[PR] [ISSUE #8534] Supports timer message queries [rocketmq]
leizhiyuan opened a new pull request, #8535:
URL: https://github.com/apache/rocketmq/pull/8535
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #8534
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
Since the topic of the current timer message is not registered with ns, there is a problem with queryMessage queries directly through the SDK. The dashboard also does not allow you to select this topic
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
<img width="1732" alt="image" src="https://github.com/user-attachments/assets/c0274e22-bf9f-4065-82a1-bf26a5253007">
<img width="1572" alt="image" src="https://github.com/user-attachments/assets/7f533263-407f-4739-a771-c56f89ceb7ec">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8534] Supports timer message queries [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8535:
URL: https://github.com/apache/rocketmq/pull/8535#issuecomment-2288535283
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8535?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 46.97%. Comparing base [(`524ca4e`)](https://app.codecov.io/gh/apache/rocketmq/commit/524ca4e862b3bb4b5f713ba09dac106beff0ce98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c903ccd`)](https://app.codecov.io/gh/apache/rocketmq/commit/c903ccd1fe8d7a7d23c60a3fbe7bca2b29c67ed4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8535 +/- ##
=============================================
+ Coverage 46.95% 46.97% +0.01%
- Complexity 11324 11335 +11
=============================================
Files 1275 1275
Lines 89086 89093 +7
Branches 11461 11462 +1
=============================================
+ Hits 41829 41847 +18
+ Misses 42077 42073 -4
+ Partials 5180 5173 -7
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8535?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8534] Supports timer message queries [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #8535:
URL: https://github.com/apache/rocketmq/pull/8535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org