You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Sergiy Matusevych (Jira)" <ji...@apache.org> on 2020/08/07 02:00:10 UTC
[jira] [Created] (REEF-2066) Some end-to-end tests hang
indefinitely
Sergiy Matusevych created REEF-2066:
---------------------------------------
Summary: Some end-to-end tests hang indefinitely
Key: REEF-2066
URL: https://issues.apache.org/jira/browse/REEF-2066
Project: REEF
Issue Type: Improvement
Components: REEF Client, REEF Driver
Reporter: Sergiy Matusevych
Assignee: Sergiy Matusevych
Some unit tests hang indefinitely in the client after launching the driver and fail to stop the job by timeout. That probably started to happen after the Netty upgrade. The behavior is consistent and reproducible.
Unit test to check: {{org.apache.reef.examples.hello.HelloHttpTest}} in {{reef-examples}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [jira] [Created] (REEF-2066) Some end-to-end tests hang indefinitely
Posted by Sergiy Matusevych <se...@gmail.com>.
Thank you! Now we can do a long-awaited release! Expect REEF 0.16.1 soon!
Cheers,
Sergiy.
On Mon, Nov 9, 2020 at 9:16 AM Dongjoon Hyun <do...@gmail.com>
wrote:
> Thank you, Sergiy.
>
> I reviewed and merged it as a valid reverting commit.
>
> Bests,
> Dongjoon.
>
>
> On Sun, Nov 8, 2020 at 9:58 PM Sergiy Matusevych <
> sergiy.matusevych@gmail.com> wrote:
>
> > ok guys, I think I've figured out this one. Please see a new PR on
> GitHub.
> > The problem was that some of our unit tests depend on the client app
> > killing the driver by timeout. For that, submitting a local process to
> the
> > process executor must return immediately after the submission - i.e. we
> > cannot call .get() on the process feature immediately after the
> submission.
> > I had to revert the PR that introduced that change. Now all unit tests go
> > through on my PC, and if everything goes well on CI, I think we can
> finally
> > do a new release of REEF.
> >
> > Can someone take a look at the new PR and merge it?
> >
> > Thank you,
> > Sergiy.
> >
> >
> >
> > On Thu, Aug 6, 2020 at 7:14 PM Sergiy Matusevych <
> > sergiy.matusevych@gmail.com> wrote:
> >
> > > Hi REEF team,
> > >
> > > This one is a blocker. I've started working on the minor release
> (0.16.1)
> > > after all recent package upgrades, and found out that some unit tests
> > hang
> > > consistently in the client. I'm looking at it now, but the more
> eyeballs
> > > the better. Can you guys take a look at issue REEF-2066 and run unit
> test
> > > org.apache.reef.examples.hello.HelloHttpTest from reef-examples on your
> > PC,
> > > too? I'll keep you updated on my progress.
> > >
> > > Thank you,
> > > Sergiy.
> > >
> > >
> > > On Thu, Aug 6, 2020 at 7:00 PM Sergiy Matusevych (Jira) <
> jira@apache.org
> > >
> > > wrote:
> > >
> > >> Sergiy Matusevych created REEF-2066:
> > >> ---------------------------------------
> > >>
> > >> Summary: Some end-to-end tests hang indefinitely
> > >> Key: REEF-2066
> > >> URL: https://issues.apache.org/jira/browse/REEF-2066
> > >> Project: REEF
> > >> Issue Type: Improvement
> > >> Components: REEF Client, REEF Driver
> > >> Reporter: Sergiy Matusevych
> > >> Assignee: Sergiy Matusevych
> > >>
> > >>
> > >> Some unit tests hang indefinitely in the client after launching the
> > >> driver and fail to stop the job by timeout. That probably started to
> > happen
> > >> after the Netty upgrade. The behavior is consistent and reproducible.
> > >>
> > >> Unit test to check: {{org.apache.reef.examples.hello.HelloHttpTest}}
> in
> > >> {{reef-examples}}.
> > >>
> > >>
> > >>
> > >> --
> > >> This message was sent by Atlassian Jira
> > >> (v8.3.4#803005)
> > >>
> > >
> >
>
Re: [jira] [Created] (REEF-2066) Some end-to-end tests hang indefinitely
Posted by Dongjoon Hyun <do...@gmail.com>.
Thank you, Sergiy.
I reviewed and merged it as a valid reverting commit.
Bests,
Dongjoon.
On Sun, Nov 8, 2020 at 9:58 PM Sergiy Matusevych <
sergiy.matusevych@gmail.com> wrote:
> ok guys, I think I've figured out this one. Please see a new PR on GitHub.
> The problem was that some of our unit tests depend on the client app
> killing the driver by timeout. For that, submitting a local process to the
> process executor must return immediately after the submission - i.e. we
> cannot call .get() on the process feature immediately after the submission.
> I had to revert the PR that introduced that change. Now all unit tests go
> through on my PC, and if everything goes well on CI, I think we can finally
> do a new release of REEF.
>
> Can someone take a look at the new PR and merge it?
>
> Thank you,
> Sergiy.
>
>
>
> On Thu, Aug 6, 2020 at 7:14 PM Sergiy Matusevych <
> sergiy.matusevych@gmail.com> wrote:
>
> > Hi REEF team,
> >
> > This one is a blocker. I've started working on the minor release (0.16.1)
> > after all recent package upgrades, and found out that some unit tests
> hang
> > consistently in the client. I'm looking at it now, but the more eyeballs
> > the better. Can you guys take a look at issue REEF-2066 and run unit test
> > org.apache.reef.examples.hello.HelloHttpTest from reef-examples on your
> PC,
> > too? I'll keep you updated on my progress.
> >
> > Thank you,
> > Sergiy.
> >
> >
> > On Thu, Aug 6, 2020 at 7:00 PM Sergiy Matusevych (Jira) <jira@apache.org
> >
> > wrote:
> >
> >> Sergiy Matusevych created REEF-2066:
> >> ---------------------------------------
> >>
> >> Summary: Some end-to-end tests hang indefinitely
> >> Key: REEF-2066
> >> URL: https://issues.apache.org/jira/browse/REEF-2066
> >> Project: REEF
> >> Issue Type: Improvement
> >> Components: REEF Client, REEF Driver
> >> Reporter: Sergiy Matusevych
> >> Assignee: Sergiy Matusevych
> >>
> >>
> >> Some unit tests hang indefinitely in the client after launching the
> >> driver and fail to stop the job by timeout. That probably started to
> happen
> >> after the Netty upgrade. The behavior is consistent and reproducible.
> >>
> >> Unit test to check: {{org.apache.reef.examples.hello.HelloHttpTest}} in
> >> {{reef-examples}}.
> >>
> >>
> >>
> >> --
> >> This message was sent by Atlassian Jira
> >> (v8.3.4#803005)
> >>
> >
>
Re: [jira] [Created] (REEF-2066) Some end-to-end tests hang indefinitely
Posted by Sergiy Matusevych <se...@gmail.com>.
ok guys, I think I've figured out this one. Please see a new PR on GitHub.
The problem was that some of our unit tests depend on the client app
killing the driver by timeout. For that, submitting a local process to the
process executor must return immediately after the submission - i.e. we
cannot call .get() on the process feature immediately after the submission.
I had to revert the PR that introduced that change. Now all unit tests go
through on my PC, and if everything goes well on CI, I think we can finally
do a new release of REEF.
Can someone take a look at the new PR and merge it?
Thank you,
Sergiy.
On Thu, Aug 6, 2020 at 7:14 PM Sergiy Matusevych <
sergiy.matusevych@gmail.com> wrote:
> Hi REEF team,
>
> This one is a blocker. I've started working on the minor release (0.16.1)
> after all recent package upgrades, and found out that some unit tests hang
> consistently in the client. I'm looking at it now, but the more eyeballs
> the better. Can you guys take a look at issue REEF-2066 and run unit test
> org.apache.reef.examples.hello.HelloHttpTest from reef-examples on your PC,
> too? I'll keep you updated on my progress.
>
> Thank you,
> Sergiy.
>
>
> On Thu, Aug 6, 2020 at 7:00 PM Sergiy Matusevych (Jira) <ji...@apache.org>
> wrote:
>
>> Sergiy Matusevych created REEF-2066:
>> ---------------------------------------
>>
>> Summary: Some end-to-end tests hang indefinitely
>> Key: REEF-2066
>> URL: https://issues.apache.org/jira/browse/REEF-2066
>> Project: REEF
>> Issue Type: Improvement
>> Components: REEF Client, REEF Driver
>> Reporter: Sergiy Matusevych
>> Assignee: Sergiy Matusevych
>>
>>
>> Some unit tests hang indefinitely in the client after launching the
>> driver and fail to stop the job by timeout. That probably started to happen
>> after the Netty upgrade. The behavior is consistent and reproducible.
>>
>> Unit test to check: {{org.apache.reef.examples.hello.HelloHttpTest}} in
>> {{reef-examples}}.
>>
>>
>>
>> --
>> This message was sent by Atlassian Jira
>> (v8.3.4#803005)
>>
>
Re: [jira] [Created] (REEF-2066) Some end-to-end tests hang indefinitely
Posted by Sergiy Matusevych <se...@gmail.com>.
Hi REEF team,
This one is a blocker. I've started working on the minor release (0.16.1)
after all recent package upgrades, and found out that some unit tests hang
consistently in the client. I'm looking at it now, but the more eyeballs
the better. Can you guys take a look at issue REEF-2066 and run unit test
org.apache.reef.examples.hello.HelloHttpTest from reef-examples on your PC,
too? I'll keep you updated on my progress.
Thank you,
Sergiy.
On Thu, Aug 6, 2020 at 7:00 PM Sergiy Matusevych (Jira) <ji...@apache.org>
wrote:
> Sergiy Matusevych created REEF-2066:
> ---------------------------------------
>
> Summary: Some end-to-end tests hang indefinitely
> Key: REEF-2066
> URL: https://issues.apache.org/jira/browse/REEF-2066
> Project: REEF
> Issue Type: Improvement
> Components: REEF Client, REEF Driver
> Reporter: Sergiy Matusevych
> Assignee: Sergiy Matusevych
>
>
> Some unit tests hang indefinitely in the client after launching the driver
> and fail to stop the job by timeout. That probably started to happen after
> the Netty upgrade. The behavior is consistent and reproducible.
>
> Unit test to check: {{org.apache.reef.examples.hello.HelloHttpTest}} in
> {{reef-examples}}.
>
>
>
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)
>