[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1133: MINIFICPP-1425 upgrade compilers on linux and mac, use C++17, prepare for C++20

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #1133:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1133#discussion_r673834998



##########
File path: debian.sh
##########
@@ -21,10 +21,17 @@ verify_enable_platform(){
   verify_gcc_enable "$feature"
 }
 add_os_flags() {
-  CMAKE_BUILD_COMMAND="${CMAKE_BUILD_COMMAND}"
+  #CMAKE_BUILD_COMMAND="${CMAKE_BUILD_COMMAND}"

Review comment:
       Could this be removed here as well?

##########
File path: arch.sh
##########
@@ -21,7 +21,8 @@ verify_enable_platform(){
     verify_gcc_enable "${feature}"
 }
 add_os_flags() {
-    CMAKE_BUILD_COMMAND="${CMAKE_BUILD_COMMAND}"
+    #CMAKE_BUILD_COMMAND="${CMAKE_BUILD_COMMAND}"

Review comment:
       Could this be removed?

##########
File path: .github/workflows/ci.yml
##########
@@ -196,7 +110,13 @@ jobs:
           echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV
           echo -e "127.0.0.1\t$HOSTNAME" | sudo tee -a /etc/hosts > /dev/null
       - name: build
-        run: ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS= -DCMAKE_BUILD_TYPE=Release -DENABLE_BUSTACHE=ON -DENABLE_SQL=ON -DENABLE_PCAP=ON -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && make -j4 VERBOSE=1
+        run: |
+          ./bootstrap.sh -e -t
+          cd build
+          export CC=gcc-11
+          export CXX=g++-11
+          cmake -DUSE_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -DENABLE_BUSTACHE=ON -DENABLE_SQL=ON -DENABLE_PCAP=ON -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON ..

Review comment:
       With the ubuntu_16_04_all job removed we don't have a job building all extensions with GCC, only with clang. We could add those in the ubuntu_20_04 job.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org