You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by "phongn (via GitHub)" <gi...@apache.org> on 2023/11/29 06:20:02 UTC

Re: [PR] Remove POSIX_THREAD constants and fix unmigrated HAVE_PTHREAD_MUTEXATTR_SETTYPE [trafficserver]

phongn commented on code in PR #10867:
URL: https://github.com/apache/trafficserver/pull/10867#discussion_r1408798993


##########
src/tscore/ink_mutex.cc:
##########
@@ -35,7 +35,7 @@ class x_pthread_mutexattr_t
   x_pthread_mutexattr_t()
   {
     pthread_mutexattr_init(&attr);
-#ifndef POSIX_THREAD_10031c
+#if HAVE_PTHREAD_MUTEXATTR_SETPSHARED
     pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);

Review Comment:
   Continued investigation of the old SVN import indicates that this dates to at least v2.0.1(!) and SVN r831143 (the initial open-source import) and that `POSIX_THREAD_10031c` was defined on a Linux, FreeBSD or Darwin system. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org