[jira] Updated: (QPID-312) Inconsistency in naming conventions

["Tomas Restrepo (JIRA)" <qp...@incubator.apache.org>]

     [ https://issues.apache.org/jira/browse/QPID-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomas Restrepo updated QPID-312:
--------------------------------

    Attachment: QPID-312.diff

Attached an initial patch to start addressing these issues:

- Renames some missing interfaces to add the I prefix
- Fixes a lot of the classes with methods in pascalCase
- Changes a number of get/set methods in interfaces for proper properties
- Converts a number of comments in classes still in javadoc style into proper C# XML comments

Most notably missing in the changes is most of the ByteBuffer related stuff, since changing it would break the spec generated code. 

> Inconsistency in naming conventions
> -----------------------------------
>
>                 Key: QPID-312
>                 URL: https://issues.apache.org/jira/browse/QPID-312
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Dot Net Client
>    Affects Versions: M2
>            Reporter: Tomas Restrepo
>            Priority: Trivial
>         Attachments: QPID-312.diff
>
>
> There is some inconsistency at this time naming conventions that would be good to resolve:
> 1- Some interfaces still have their original java-like name without the I prefix, which is the usual .NET convention. Examples: ByteBufferAllocator, BrokerInfo, ConnectionInfo
> 2- Some classes that use the Amq prefix while others most use AMQ (like AmqBrokerInfo and AmqChannel). The latter is the recommended convention by FxCop, but it doesn't matter much as long as we're consistent.
> 3- A lot of classes ported from Java still have methods named using the original java convention (camelCase).
> 4- Some namespaces are stil in camelCase (example Qpid.Client.qms)
> At least for 2 we should decide what the convention will be so that code can be adapted and be consistent in this regard.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.