You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shawn Heisey (JIRA)" <ji...@apache.org> on 2018/09/18 21:37:00 UTC
[jira] [Commented] (SOLR-4390) SolrJ does not URL-encode query
string argument names but should
[ https://issues.apache.org/jira/browse/SOLR-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619761#comment-16619761 ]
Shawn Heisey commented on SOLR-4390:
------------------------------------
I had thought that field names were subject to validation, but it appears that only shard names, collection names, core names, and alias names are actually validated.
https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;a=blob;f=solr/solrj/src/java/org/apache/solr/client/solrj/util/SolrIdentifierValidator.java;h=d23b8bbf93d5cdd3da3d68c135e0d8233f1571dd
IMHO, field names and other identifiers should be subject to the same validation requirements. None of the characters in the validation list require URL encoding.
> SolrJ does not URL-encode query string argument names but should
> ----------------------------------------------------------------
>
> Key: SOLR-4390
> URL: https://issues.apache.org/jira/browse/SOLR-4390
> Project: Solr
> Issue Type: Bug
> Components: clients - java, SolrJ
> Affects Versions: 4.1
> Reporter: Karl Wright
> Priority: Major
> Attachments: SOLR-4390.patch
>
>
> SolrJ does not appear to URL-encode any metadata names, but should. This leads to URLs that are illegal, and thus an IllegalArgumentException gets thrown. See CONNECTORS-630 for an example of a bad URL that SolrJ generates.
> I understand that this may have been broken for a long time and that now backwards-compatibility is an issue, but it should still be possible to tell SolrJ to do the right thing and not make the SolrJ user do it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org