[jira] [Commented] (KNOX-2736) Knox clients should support retry/failover

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557906#comment-17557906 ] 

ASF subversion and git services commented on KNOX-2736:
-------------------------------------------------------

Commit 7ac870f16563eda499b7eafa072bb119f4cd5754 in knox's branch refs/heads/dependabot/npm_and_yarn/knox-token-management-ui/minimist-1.2.6 from Attila Magyar
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=7ac870f16 ]

KNOX-2736 Knox clients should support retry/failover (#568)



> Knox clients should support retry/failover
> ------------------------------------------
>
>                 Key: KNOX-2736
>                 URL: https://issues.apache.org/jira/browse/KNOX-2736
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: KnoxShell
>            Reporter: Attila Magyar
>            Assignee: Attila Magyar
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Not having retries in knox clients can cause service upgrade failures.
> The apache http client has a default mechanism (StandardHttpRequestRetryHandler and DefaultServiceUnavailableRetryStrategy) to support retries.
> * DefaultServiceUnavailableRetryStrategy only retries in case of a 503 - ServiceUnavailable.
> * StandardHttpRequestRetryHandler retries when a non excluded exception occurs during the request.
> The excluded exceptions are: InterruptedIOException, UnknownHostException, ConnectException, SSLException. In these cases no retry is going to happen.
> The following HTTP methods are considered idempotent so they can be retried: GET, HEAD, PUT, DELETE, OPTIONS, TRACE.
> Note that if an endpoint is implemented as a non-idempotent way (for example a PUT) then this might have unwanted side-effects.
> Other methods such as POST are only retried if the request has not yet written out to the output stream when the error happened. Or if requestSentRetryEnabled is enabled.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)