You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Charles Chen <cc...@google.com> on 2018/09/25 02:58:56 UTC
[VOTE] Release 2.7.0, release candidate #2
Hi everyone,
Please review and vote on the release candidate #2 for the version 2.7.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org [2],
which is signed with the key with fingerprint 45C60AAAD115F560 [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "v2.7.0-RC2" [5],
* website pull request listing the release and publishing the API reference
manual [6].
* Java artifacts were built with Gradle 4.8 and OpenJDK
1.8.0_181-8u181-b13-1~deb9u1.
* Python artifacts are deployed along with the source release to the
dist.apache.org [2].
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Charles
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12343654
[2] https://dist.apache.org/repos/dist/dev/beam/2.7.0
[3] https://dist.apache.org/repos/dist/dev/beam/KEYS
[4] https://repository.apache.org/content/repositories/orgapachebeam-1047/
[5] https://github.com/apache/beam/tree/v2.7.0-RC2
[6] https://github.com/apache/beam-site/pull/549
Re: [VOTE] Release 2.7.0, release candidate #2
Posted by Charles Chen <cc...@google.com>.
I have merged https://github.com/apache/beam/pull/6494 and
https://github.com/apache/beam/pull/6495 which revert the offending commit
in master and release-2.7.0, respectively. I am building 2.7.0 RC3 which
will be out shortly.
On Tue, Sep 25, 2018 at 9:52 PM Charles Chen <cc...@google.com> wrote:
> Unfortunately, I have to -1 this RC. There is a problem with the Python
> release validation. Specifically, wordcount on the local DirectRunner
> fails with:
>
> *21:02:11* ERROR:root:Exception in _rename_batch. src: /tmp/tmp.PqwH113fm4/beam-temp-wordcount_direct.txt-cb5837b8c12711e8981742010a800020/5d1be1d0-bc76-4d30-90e4-bf76f30e17a0.wordcount_direct.txt, dst: wordcount_direct.txt-00000-of-00001, err: [Errno 2] No such file or directory: ''
>
>
> https://builds.apache.org/job/beam_PostRelease_Python_Candidate/133/console
>
> I ran a git bisect and identified https://github.com/apache/beam/pull/5903
> as the culprit (it looks like the change doesn't deal well with relative
> paths):
>
> d903dcfc7ff7300355688b08b779da880f15fe9d is the first bad commit
> commit d903dcfc7ff7300355688b08b779da880f15fe9d
> Author: Ryan Williams <ry...@gmail.com>
> Date: Fri Jul 27 19:46:19 2018 -0400
>
> [BEAM-4747] mkdirs if they don't exist in localfilesystem (#5903)
>
> * mkdirs if they don't exist in localfilesystem
> * make localfilesystem create ancestor directories for output paths
>
> :040000 040000 4f66c0745f0cb28fbc9527657da7d9126d685f99 b48a4cca7dd3454d1babeb1b0ed15d7b6912f046 M sdks
> bisect run success
>
>
> On Tue, Sep 25, 2018 at 4:53 PM Charles Chen <cc...@google.com> wrote:
>
>> Hi all, please add any validation performed to the spreadsheet here:
>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1675964688
>>
>> On Tue, Sep 25, 2018 at 12:11 PM Romain Manni-Bucau <
>> rmannibucau@gmail.com> wrote:
>>
>>> +1 tested spark local and a 1 node cluster, direct runner and java test
>>> tools
>>>
>>> Le mar. 25 sept. 2018 13:08, Łukasz Gajowy <lu...@gmail.com> a
>>> écrit :
>>>
>>>> +1
>>>>
>>>> I ran the Java - Quickstart on core runners (local) and Dataflow
>>>> Quickstarts (on Dataflow instance) either way. Looks good. I wanted to
>>>> learn how easy it is - kudos to the author of the script! :)
>>>>
>>>> wt., 25 wrz 2018 o 12:39 Robert Bradshaw <ro...@google.com>
>>>> napisał(a):
>>>>
>>>>> +1 (binding)
>>>>>
>>>>> I verified all the signatures and hashes, as well as one of the Python
>>>>> wheels, and that we're not shipping gradle[w] but otherwise the content
>>>>> matches the git repo (except a SNAPSHOT vs version change to the source).
>>>>>
>>>>> The changes [1] look minimal compared to RC1, so most of the
>>>>> verification there should apply as well.
>>>>>
>>>>> [1] https://github.com/apache/beam/compare/v2.7.0-RC1...v2.7.0-RC2
>>>>>
>>>>> On Tue, Sep 25, 2018 at 4:59 AM Charles Chen <cc...@google.com> wrote:
>>>>>
>>>>>> Hi everyone,
>>>>>>
>>>>>> Please review and vote on the release candidate #2 for the version
>>>>>> 2.7.0, as follows:
>>>>>> [ ] +1, Approve the release
>>>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>>>
>>>>>> The complete staging area is available for your review, which
>>>>>> includes:
>>>>>> * JIRA release notes [1],
>>>>>> * the official Apache source release to be deployed to
>>>>>> dist.apache.org [2], which is signed with the key with fingerprint
>>>>>> 45C60AAAD115F560 [3],
>>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>>>> * source code tag "v2.7.0-RC2" [5],
>>>>>> * website pull request listing the release and publishing the API
>>>>>> reference manual [6].
>>>>>> * Java artifacts were built with Gradle 4.8 and OpenJDK
>>>>>> 1.8.0_181-8u181-b13-1~deb9u1.
>>>>>> * Python artifacts are deployed along with the source release to the
>>>>>> dist.apache.org [2].
>>>>>>
>>>>>> The vote will be open for at least 72 hours. It is adopted by
>>>>>> majority approval, with at least 3 PMC affirmative votes.
>>>>>>
>>>>>> Thanks,
>>>>>> Charles
>>>>>>
>>>>>> [1]
>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12343654
>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.7.0
>>>>>> [3] https://dist.apache.org/repos/dist/dev/beam/KEYS
>>>>>> [4]
>>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1047/
>>>>>> [5] https://github.com/apache/beam/tree/v2.7.0-RC2
>>>>>> [6] https://github.com/apache/beam-site/pull/549
>>>>>>
>>>>>
Re: [VOTE] Release 2.7.0, release candidate #2
Posted by Charles Chen <cc...@google.com>.
Unfortunately, I have to -1 this RC. There is a problem with the Python
release validation. Specifically, wordcount on the local DirectRunner
fails with:
*21:02:11* ERROR:root:Exception in _rename_batch. src:
/tmp/tmp.PqwH113fm4/beam-temp-wordcount_direct.txt-cb5837b8c12711e8981742010a800020/5d1be1d0-bc76-4d30-90e4-bf76f30e17a0.wordcount_direct.txt,
dst: wordcount_direct.txt-00000-of-00001, err: [Errno 2] No such file
or directory: ''
https://builds.apache.org/job/beam_PostRelease_Python_Candidate/133/console
I ran a git bisect and identified https://github.com/apache/beam/pull/5903
as the culprit (it looks like the change doesn't deal well with relative
paths):
d903dcfc7ff7300355688b08b779da880f15fe9d is the first bad commit
commit d903dcfc7ff7300355688b08b779da880f15fe9d
Author: Ryan Williams <ry...@gmail.com>
Date: Fri Jul 27 19:46:19 2018 -0400
[BEAM-4747] mkdirs if they don't exist in localfilesystem (#5903)
* mkdirs if they don't exist in localfilesystem
* make localfilesystem create ancestor directories for output paths
:040000 040000 4f66c0745f0cb28fbc9527657da7d9126d685f99
b48a4cca7dd3454d1babeb1b0ed15d7b6912f046 M sdks
bisect run success
On Tue, Sep 25, 2018 at 4:53 PM Charles Chen <cc...@google.com> wrote:
> Hi all, please add any validation performed to the spreadsheet here:
> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1675964688
>
> On Tue, Sep 25, 2018 at 12:11 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
>> +1 tested spark local and a 1 node cluster, direct runner and java test
>> tools
>>
>> Le mar. 25 sept. 2018 13:08, Łukasz Gajowy <lu...@gmail.com> a
>> écrit :
>>
>>> +1
>>>
>>> I ran the Java - Quickstart on core runners (local) and Dataflow
>>> Quickstarts (on Dataflow instance) either way. Looks good. I wanted to
>>> learn how easy it is - kudos to the author of the script! :)
>>>
>>> wt., 25 wrz 2018 o 12:39 Robert Bradshaw <ro...@google.com>
>>> napisał(a):
>>>
>>>> +1 (binding)
>>>>
>>>> I verified all the signatures and hashes, as well as one of the Python
>>>> wheels, and that we're not shipping gradle[w] but otherwise the content
>>>> matches the git repo (except a SNAPSHOT vs version change to the source).
>>>>
>>>> The changes [1] look minimal compared to RC1, so most of the
>>>> verification there should apply as well.
>>>>
>>>> [1] https://github.com/apache/beam/compare/v2.7.0-RC1...v2.7.0-RC2
>>>>
>>>> On Tue, Sep 25, 2018 at 4:59 AM Charles Chen <cc...@google.com> wrote:
>>>>
>>>>> Hi everyone,
>>>>>
>>>>> Please review and vote on the release candidate #2 for the version
>>>>> 2.7.0, as follows:
>>>>> [ ] +1, Approve the release
>>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>>
>>>>> The complete staging area is available for your review, which includes:
>>>>> * JIRA release notes [1],
>>>>> * the official Apache source release to be deployed to dist.apache.org
>>>>> [2], which is signed with the key with fingerprint 45C60AAAD115F560 [3],
>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>>> * source code tag "v2.7.0-RC2" [5],
>>>>> * website pull request listing the release and publishing the API
>>>>> reference manual [6].
>>>>> * Java artifacts were built with Gradle 4.8 and OpenJDK
>>>>> 1.8.0_181-8u181-b13-1~deb9u1.
>>>>> * Python artifacts are deployed along with the source release to the
>>>>> dist.apache.org [2].
>>>>>
>>>>> The vote will be open for at least 72 hours. It is adopted by majority
>>>>> approval, with at least 3 PMC affirmative votes.
>>>>>
>>>>> Thanks,
>>>>> Charles
>>>>>
>>>>> [1]
>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12343654
>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.7.0
>>>>> [3] https://dist.apache.org/repos/dist/dev/beam/KEYS
>>>>> [4]
>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1047/
>>>>> [5] https://github.com/apache/beam/tree/v2.7.0-RC2
>>>>> [6] https://github.com/apache/beam-site/pull/549
>>>>>
>>>>
Re: [VOTE] Release 2.7.0, release candidate #2
Posted by Charles Chen <cc...@google.com>.
Hi all, please add any validation performed to the spreadsheet here:
https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1675964688
On Tue, Sep 25, 2018 at 12:11 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> +1 tested spark local and a 1 node cluster, direct runner and java test
> tools
>
> Le mar. 25 sept. 2018 13:08, Łukasz Gajowy <lu...@gmail.com> a
> écrit :
>
>> +1
>>
>> I ran the Java - Quickstart on core runners (local) and Dataflow
>> Quickstarts (on Dataflow instance) either way. Looks good. I wanted to
>> learn how easy it is - kudos to the author of the script! :)
>>
>> wt., 25 wrz 2018 o 12:39 Robert Bradshaw <ro...@google.com>
>> napisał(a):
>>
>>> +1 (binding)
>>>
>>> I verified all the signatures and hashes, as well as one of the Python
>>> wheels, and that we're not shipping gradle[w] but otherwise the content
>>> matches the git repo (except a SNAPSHOT vs version change to the source).
>>>
>>> The changes [1] look minimal compared to RC1, so most of the
>>> verification there should apply as well.
>>>
>>> [1] https://github.com/apache/beam/compare/v2.7.0-RC1...v2.7.0-RC2
>>>
>>> On Tue, Sep 25, 2018 at 4:59 AM Charles Chen <cc...@google.com> wrote:
>>>
>>>> Hi everyone,
>>>>
>>>> Please review and vote on the release candidate #2 for the version
>>>> 2.7.0, as follows:
>>>> [ ] +1, Approve the release
>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>
>>>> The complete staging area is available for your review, which includes:
>>>> * JIRA release notes [1],
>>>> * the official Apache source release to be deployed to dist.apache.org
>>>> [2], which is signed with the key with fingerprint 45C60AAAD115F560 [3],
>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>> * source code tag "v2.7.0-RC2" [5],
>>>> * website pull request listing the release and publishing the API
>>>> reference manual [6].
>>>> * Java artifacts were built with Gradle 4.8 and OpenJDK
>>>> 1.8.0_181-8u181-b13-1~deb9u1.
>>>> * Python artifacts are deployed along with the source release to the
>>>> dist.apache.org [2].
>>>>
>>>> The vote will be open for at least 72 hours. It is adopted by majority
>>>> approval, with at least 3 PMC affirmative votes.
>>>>
>>>> Thanks,
>>>> Charles
>>>>
>>>> [1]
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12343654
>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.7.0
>>>> [3] https://dist.apache.org/repos/dist/dev/beam/KEYS
>>>> [4]
>>>> https://repository.apache.org/content/repositories/orgapachebeam-1047/
>>>> [5] https://github.com/apache/beam/tree/v2.7.0-RC2
>>>> [6] https://github.com/apache/beam-site/pull/549
>>>>
>>>
Re: [VOTE] Release 2.7.0, release candidate #2
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1 tested spark local and a 1 node cluster, direct runner and java test
tools
Le mar. 25 sept. 2018 13:08, Łukasz Gajowy <lu...@gmail.com> a
écrit :
> +1
>
> I ran the Java - Quickstart on core runners (local) and Dataflow
> Quickstarts (on Dataflow instance) either way. Looks good. I wanted to
> learn how easy it is - kudos to the author of the script! :)
>
> wt., 25 wrz 2018 o 12:39 Robert Bradshaw <ro...@google.com> napisał(a):
>
>> +1 (binding)
>>
>> I verified all the signatures and hashes, as well as one of the Python
>> wheels, and that we're not shipping gradle[w] but otherwise the content
>> matches the git repo (except a SNAPSHOT vs version change to the source).
>>
>> The changes [1] look minimal compared to RC1, so most of the verification
>> there should apply as well.
>>
>> [1] https://github.com/apache/beam/compare/v2.7.0-RC1...v2.7.0-RC2
>>
>> On Tue, Sep 25, 2018 at 4:59 AM Charles Chen <cc...@google.com> wrote:
>>
>>> Hi everyone,
>>>
>>> Please review and vote on the release candidate #2 for the version
>>> 2.7.0, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release to be deployed to dist.apache.org
>>> [2], which is signed with the key with fingerprint 45C60AAAD115F560 [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag "v2.7.0-RC2" [5],
>>> * website pull request listing the release and publishing the API
>>> reference manual [6].
>>> * Java artifacts were built with Gradle 4.8 and OpenJDK
>>> 1.8.0_181-8u181-b13-1~deb9u1.
>>> * Python artifacts are deployed along with the source release to the
>>> dist.apache.org [2].
>>>
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PMC affirmative votes.
>>>
>>> Thanks,
>>> Charles
>>>
>>> [1]
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12343654
>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.7.0
>>> [3] https://dist.apache.org/repos/dist/dev/beam/KEYS
>>> [4]
>>> https://repository.apache.org/content/repositories/orgapachebeam-1047/
>>> [5] https://github.com/apache/beam/tree/v2.7.0-RC2
>>> [6] https://github.com/apache/beam-site/pull/549
>>>
>>
Re: [VOTE] Release 2.7.0, release candidate #2
Posted by Łukasz Gajowy <lu...@gmail.com>.
+1
I ran the Java - Quickstart on core runners (local) and Dataflow
Quickstarts (on Dataflow instance) either way. Looks good. I wanted to
learn how easy it is - kudos to the author of the script! :)
wt., 25 wrz 2018 o 12:39 Robert Bradshaw <ro...@google.com> napisał(a):
> +1 (binding)
>
> I verified all the signatures and hashes, as well as one of the Python
> wheels, and that we're not shipping gradle[w] but otherwise the content
> matches the git repo (except a SNAPSHOT vs version change to the source).
>
> The changes [1] look minimal compared to RC1, so most of the verification
> there should apply as well.
>
> [1] https://github.com/apache/beam/compare/v2.7.0-RC1...v2.7.0-RC2
>
> On Tue, Sep 25, 2018 at 4:59 AM Charles Chen <cc...@google.com> wrote:
>
>> Hi everyone,
>>
>> Please review and vote on the release candidate #2 for the version 2.7.0,
>> as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to dist.apache.org
>> [2], which is signed with the key with fingerprint 45C60AAAD115F560 [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag "v2.7.0-RC2" [5],
>> * website pull request listing the release and publishing the API
>> reference manual [6].
>> * Java artifacts were built with Gradle 4.8 and OpenJDK
>> 1.8.0_181-8u181-b13-1~deb9u1.
>> * Python artifacts are deployed along with the source release to the
>> dist.apache.org [2].
>>
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>>
>> Thanks,
>> Charles
>>
>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12343654
>> [2] https://dist.apache.org/repos/dist/dev/beam/2.7.0
>> [3] https://dist.apache.org/repos/dist/dev/beam/KEYS
>> [4]
>> https://repository.apache.org/content/repositories/orgapachebeam-1047/
>> [5] https://github.com/apache/beam/tree/v2.7.0-RC2
>> [6] https://github.com/apache/beam-site/pull/549
>>
>
Re: [VOTE] Release 2.7.0, release candidate #2
Posted by Robert Bradshaw <ro...@google.com>.
+1 (binding)
I verified all the signatures and hashes, as well as one of the Python
wheels, and that we're not shipping gradle[w] but otherwise the content
matches the git repo (except a SNAPSHOT vs version change to the source).
The changes [1] look minimal compared to RC1, so most of the verification
there should apply as well.
[1] https://github.com/apache/beam/compare/v2.7.0-RC1...v2.7.0-RC2
On Tue, Sep 25, 2018 at 4:59 AM Charles Chen <cc...@google.com> wrote:
> Hi everyone,
>
> Please review and vote on the release candidate #2 for the version 2.7.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2], which is signed with the key with fingerprint 45C60AAAD115F560 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "v2.7.0-RC2" [5],
> * website pull request listing the release and publishing the API
> reference manual [6].
> * Java artifacts were built with Gradle 4.8 and OpenJDK
> 1.8.0_181-8u181-b13-1~deb9u1.
> * Python artifacts are deployed along with the source release to the
> dist.apache.org [2].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Charles
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12343654
> [2] https://dist.apache.org/repos/dist/dev/beam/2.7.0
> [3] https://dist.apache.org/repos/dist/dev/beam/KEYS
> [4] https://repository.apache.org/content/repositories/orgapachebeam-1047/
> [5] https://github.com/apache/beam/tree/v2.7.0-RC2
> [6] https://github.com/apache/beam-site/pull/549
>