You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/12 13:36:28 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5017: Usage: usage generated for destroyed VMs with no backups

sureshanaparti commented on a change in pull request #5017:
URL: https://github.com/apache/cloudstack/pull/5017#discussion_r631047733



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2279,6 +2283,7 @@ public boolean expunge(UserVmVO vm, long callerUserId, Account caller) {
                     return false;
                 }
 
+                unassignBackupOffering(vm.getId());

Review comment:
       @Pearl1594 possible to call remove / unassign backup from backup manager here? unassign offering code will be at single place, easy to maintain.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org