You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2016/11/14 04:39:58 UTC

[jira] [Updated] (LUCENE-7559) UnifiedHighlighter: Make Passage public for extensibility

     [ https://issues.apache.org/jira/browse/LUCENE-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated LUCENE-7559:
---------------------------------
    Attachment: LUCENE-7559.patch

This patch makes it's fields private, adds setters, and makes the package visible methods public.  {{/** @lucene.internal */}} was added to methods only needed internally.

> UnifiedHighlighter: Make Passage public for extensibility
> ---------------------------------------------------------
>
>                 Key: LUCENE-7559
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7559
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-7559.patch
>
>
> (UnifiedHighlighter) Passage.java has a variety of package-level fields and methods that are accessed by FieldHighlighter.highlightOffsetsEnums (the kernel of the UH).  It should be possible for people to extend this method to tweak the process of producing passages.  That method is extensible but Passage.java is too closed.  Even if one were to write their own equivalent to Passage.java, it would be impossible to then use PassageScorer or PassageFormatter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org