You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/23 00:22:35 UTC
[GitHub] [spark] ulysses-you commented on a change in pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019
ulysses-you commented on a change in pull request #29842:
URL: https://github.com/apache/spark/pull/29842#discussion_r493104670
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -529,37 +529,39 @@ class FileSourceStrategySuite extends QueryTest with SharedSparkSession with Pre
}
test("SPARK-32019: Add spark.sql.files.minPartitionNum config") {
- withSQLConf(SQLConf.FILES_MIN_PARTITION_NUM.key -> "1") {
- val table =
- createTable(files = Seq(
- "file1" -> 1,
- "file2" -> 1,
- "file3" -> 1
- ))
- assert(table.rdd.partitions.length == 1)
- }
+ withSQLConf(SQLConf.FILES_MAX_PARTITION_BYTES.key -> "2MB") {
Review comment:
Can we add the config `spark.sql.files.openCostInBytes` ? The result is based on it although we don't change the default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org