You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 08:58:05 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #10491: Add a possibility to switch back to building images by secret
potiuk commented on a change in pull request #10491:
URL: https://github.com/apache/airflow/pull/10491#discussion_r475441741
##########
File path: .github/workflows/ci.yml
##########
@@ -56,9 +56,10 @@ env:
#
# GITHUB_REGISTRY_WAIT_FOR_IMAGE: "false"
#
+ # You can also switch back to building images locally and disabling the "Build Images" workflow
+ # by defining AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE secret with value set to "false"
- GITHUB_REGISTRY_WAIT_FOR_IMAGE: "true"
-
+ GITHUB_REGISTRY_WAIT_FOR_IMAGE: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE != 'false' }}
Review comment:
As explained below - I only want the secret to trigger the "BUILD_IMAGE=false" if it is defined and it has "false" value. So the condition is actually OK :)
##########
File path: .github/workflows/ci.yml
##########
@@ -56,9 +56,10 @@ env:
#
# GITHUB_REGISTRY_WAIT_FOR_IMAGE: "false"
#
+ # You can also switch back to building images locally and disabling the "Build Images" workflow
+ # by defining AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE secret with value set to "false"
- GITHUB_REGISTRY_WAIT_FOR_IMAGE: "true"
-
+ GITHUB_REGISTRY_WAIT_FOR_IMAGE: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE != 'false' }}
Review comment:
I pushed back the original change
##########
File path: .github/workflows/build-images-workflow-run.yml
##########
@@ -39,6 +39,7 @@ env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_REGISTRY_PULL_IMAGE_TAG: "latest"
GITHUB_REGISTRY_WAIT_FOR_IMAGE: "false"
+ BUILD_IMAGES: ${{ secrets.AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE != 'false' }}
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org