[Fwd: Re: lint errors after upgrade]

["Daryl C. W. O'Shea" <sp...@dostech.ca>]

Why do we have Logger.pm converting spaces to underscores?  This seems 
to be causing nothing but confusion of users.


-------- Original Message --------
Subject: Re: lint errors after upgrade
Date: Wed, 22 Mar 2006 14:56:22 -0500
From: Matt Kettler <mk...@evi-inc.com>
To: Jean-Paul Natola <jn...@familycareintl.org>
CC: users@spamassassin.apache.org
References: <3A...@www.fcimail.org>

Jean-Paul Natola wrote:
> Hi all
> 
> After upgrading to 3.1.1
> 
> I'm getting a bunch of 
> 
> 
> [36993] warn: config: SpamAssassin failed to parse line,
> "SARE_RMML_Stock27_.166" is not valid for "score", skipping:
> score_SARE_RMML_Stock27_.166
> 
> Is there something , or should I say, what step did I miss?
> 

Looks like you're using sare_stocks.cf, and you have a corrupted version


It should be:

score SARE_RMML_Stock27 .166

Not:

score_SARE_RMML_Stock27_.166

Re: [Fwd: Re: lint errors after upgrade]

[Theo Van Dinter <fe...@apache.org>]

On Thu, Mar 23, 2006 at 11:16:39AM +0000, Justin Mason wrote:
> > > how about we do something like this instead:
> > Sounds good (a lot better) to me.  Something for 3.1.2.
> +1

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4839

:)

-- 
Randomly Generated Tagline:
"Of course, the more I learn, the more I realize I don't know.  At some
 point, I hope to learn enough to realize that I know nothing at all.
 Then maybe I'll be able to snatch a pebble from Julia Child's hand."
         - Alton Brown, "I'm Just Here For The Food"

Re: [Fwd: Re: lint errors after upgrade]

["Daryl C. W. O'Shea" <sp...@dostech.ca>]

Theo Van Dinter wrote:
> On Thu, Mar 23, 2006 at 01:52:56AM -0500, Daryl C. W. O'Shea wrote:
>> Why do we have Logger.pm converting spaces to underscores?  This seems 
>> to be causing nothing but confusion of users.
> 
> fwiw, it's not spaces:
> 
>     $line =~ s/[\x00-\x1f]/_/gm; # replace control characters with "_"
> 
> tab ('\t') is in that range.

Ah, I didn't look.  I just recalled Michael mentioning it last week or so.


> how about we do something like this instead:
> 
> $line =~ tr/\x09\x20\x00-\x1f/  _/s;
> 
> it'll replace multiple tabs and spaces with a single space, and the
> other control chars with an underscore.

Sounds good (a lot better) to me.  Something for 3.1.2.


Daryl

Re: [Fwd: Re: lint errors after upgrade]

[Theo Van Dinter <fe...@apache.org>]

On Thu, Mar 23, 2006 at 01:52:56AM -0500, Daryl C. W. O'Shea wrote:
> Why do we have Logger.pm converting spaces to underscores?  This seems 
> to be causing nothing but confusion of users.

fwiw, it's not spaces:

    $line =~ s/[\x00-\x1f]/_/gm; # replace control characters with "_"

tab ('\t') is in that range.

how about we do something like this instead:

$line =~ tr/\x09\x20\x00-\x1f/  _/s;

it'll replace multiple tabs and spaces with a single space, and the
other control chars with an underscore.

-- 
Randomly Generated Tagline:
Q. How many Microsoft Engineers does it take to change a light bulb ?
 A. None. Bill Gates will just redefine Darkness (TM) as the new
    industry standard.  ;)