[GitHub] [spark] stczwd edited a comment on pull request #35549: [SPARK-38230][SQL] InsertIntoHadoopFsRelationCommand unnecessarily fetches details of partitions in most cases

[GitBox <gi...@apache.org>]

stczwd edited a comment on pull request #35549:
URL: https://github.com/apache/spark/pull/35549#issuecomment-1062790013


   Hm, I got your mind. After looking at the relevant logic, `customPartitionLocations` will only be used while overwriting hive static partition.
   Thus, changing `listPartitions` to `listPartitionNames` by default, and calling `listPartitions` before `deleteMatchingPartitions` is a better idea. It will not add much time for static partition overwriting as `listPartitions` for staticPartition won't take any time.
   cc @cloud-fan @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org