You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Takanobu Asanuma (JIRA)" <ji...@apache.org> on 2019/06/12 06:57:00 UTC

[jira] [Comment Edited] (HDFS-14036) RBF: Add hdfs-rbf-default.xml to HdfsConfiguration by default

    [ https://issues.apache.org/jira/browse/HDFS-14036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861807#comment-16861807 ] 

Takanobu Asanuma edited comment on HDFS-14036 at 6/12/19 6:56 AM:
------------------------------------------------------------------

{{TestRouterRpc}} passed in my local computer and seems not to be related.

After loading {{hdfs-rbf-default.xml}}, {{routerOverrides}} in {{MiniRouterDFSCluster#generateRouterConfiguration}} overrides the test specific router configurations by default values. That was the cause of the many failed tests. The 004.patch initializes(not overrides) router configurations.

[~elgoiri] [~crh] I think 004.patch is valid. Could you review it?


was (Author: tasanuma0829):
The failed test passed in my local computer and seems not to be related.

After loading {{hdfs-rbf-default.xml}}, {{routerOverrides}} in {{MiniRouterDFSCluster#generateRouterConfiguration}} overrides the test specific router configurations by default values. That was the cause of the many failed tests. The 004.patch initializes(not overrides) router configurations.

[~elgoiri] [~crh] I think 004.patch is valid. Could you review it?

> RBF: Add hdfs-rbf-default.xml to HdfsConfiguration by default
> -------------------------------------------------------------
>
>                 Key: HDFS-14036
>                 URL: https://issues.apache.org/jira/browse/HDFS-14036
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Íñigo Goiri
>            Assignee: Takanobu Asanuma
>            Priority: Major
>         Attachments: HDFS-14036-HDFS-13891.001.patch, HDFS-14036-HDFS-13891.002.patch, HDFS-14036-HDFS-13891.003.patch, HDFS-14036-HDFS-13891.004.patch, HDFS-14036.001.patch
>
>
> Currently, the default values from hdfs-rbf-default.xml are not been set by default.
> We should add them to HdfsConfiguration by default.
> This may break some unit tests so we would need to tune some RBF unit tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org