You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 09:44:30 UTC
[GitHub] [flink] shuiqiangchen opened a new pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
shuiqiangchen opened a new pull request #12165:
URL: https://github.com/apache/flink/pull/12165
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
When starting the JavaGatewayServer, a callback client would also be created and run in a ScheduleExecutorService's thread which is non-daemon by default. Thus, we need to shut down the non-daemon thread and reset a daemon thread back to the call back client.
## Brief change log
- shut down the non-daemon thread and reset a daemon thread back to the call back client in startGatewayServer() in PythonDriver.py.
## Verifying this change
This pull request can be verified by all pyflink table API tests which need to start the communication between python process and java process.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): ( no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: ( no )
- The S3 file system connector: ( no )
## Documentation
- Does this pull request introduce a new feature? ( no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #12165:
URL: https://github.com/apache/flink/pull/12165#discussion_r426139537
##########
File path: flink-python/src/main/java/org/apache/flink/client/python/PythonDriver.java
##########
@@ -95,23 +104,36 @@ public static void main(String[] args) {
*
* @return The created GatewayServer
*/
- static GatewayServer startGatewayServer() {
- InetAddress localhost = InetAddress.getLoopbackAddress();
- GatewayServer gatewayServer = new GatewayServer.GatewayServerBuilder()
- .javaPort(0)
- .javaAddress(localhost)
- .build();
- Thread thread = new Thread(gatewayServer::start);
+ static GatewayServer startGatewayServer() throws InterruptedException, ExecutionException {
+ CompletableFuture<GatewayServer> gatewayServerFuture = new CompletableFuture<>();
+ Thread thread = new Thread(() -> {
+ try {
+ int freePort = NetUtils.getAvailablePort();
+ GatewayServer server = new GatewayServer.GatewayServerBuilder()
+ .gateway(new Gateway(new ConcurrentHashMap<String, Object>(), new CallbackClient(freePort)))
Review comment:
I guess the CallbackClient is not needed in 1.9 and 1.10. What's your thought? If so, the logic could be simplified a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #12165:
URL: https://github.com/apache/flink/pull/12165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12165:
URL: https://github.com/apache/flink/pull/12165#issuecomment-629158601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfa7a742fe1d051832355467854d50f03b376f91",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/166249593",
"triggerID" : "dfa7a742fe1d051832355467854d50f03b376f91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfa7a742fe1d051832355467854d50f03b376f91 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/166249593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #12165:
URL: https://github.com/apache/flink/pull/12165#issuecomment-629920046
Merged via 2bc4628876715698c9bae542e36014344a93c42b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12165:
URL: https://github.com/apache/flink/pull/12165#issuecomment-629142661
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dfa7a742fe1d051832355467854d50f03b376f91 (Fri May 15 09:49:02 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17700).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on a change in pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
shuiqiangchen commented on a change in pull request #12165:
URL: https://github.com/apache/flink/pull/12165#discussion_r426329242
##########
File path: flink-python/src/main/java/org/apache/flink/client/python/PythonDriver.java
##########
@@ -95,23 +104,36 @@ public static void main(String[] args) {
*
* @return The created GatewayServer
*/
- static GatewayServer startGatewayServer() {
- InetAddress localhost = InetAddress.getLoopbackAddress();
- GatewayServer gatewayServer = new GatewayServer.GatewayServerBuilder()
- .javaPort(0)
- .javaAddress(localhost)
- .build();
- Thread thread = new Thread(gatewayServer::start);
+ static GatewayServer startGatewayServer() throws InterruptedException, ExecutionException {
+ CompletableFuture<GatewayServer> gatewayServerFuture = new CompletableFuture<>();
+ Thread thread = new Thread(() -> {
+ try {
+ int freePort = NetUtils.getAvailablePort();
+ GatewayServer server = new GatewayServer.GatewayServerBuilder()
+ .gateway(new Gateway(new ConcurrentHashMap<String, Object>(), new CallbackClient(freePort)))
Review comment:
@dianfu Thanks for your reply! It seem that every time we new a GatewayServer, a CallbackClient would also be created, no matter whether we need to use the callback client. So, we may still need to set the executorService to be daemon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #12165:
URL: https://github.com/apache/flink/pull/12165#discussion_r426139537
##########
File path: flink-python/src/main/java/org/apache/flink/client/python/PythonDriver.java
##########
@@ -95,23 +104,36 @@ public static void main(String[] args) {
*
* @return The created GatewayServer
*/
- static GatewayServer startGatewayServer() {
- InetAddress localhost = InetAddress.getLoopbackAddress();
- GatewayServer gatewayServer = new GatewayServer.GatewayServerBuilder()
- .javaPort(0)
- .javaAddress(localhost)
- .build();
- Thread thread = new Thread(gatewayServer::start);
+ static GatewayServer startGatewayServer() throws InterruptedException, ExecutionException {
+ CompletableFuture<GatewayServer> gatewayServerFuture = new CompletableFuture<>();
+ Thread thread = new Thread(() -> {
+ try {
+ int freePort = NetUtils.getAvailablePort();
+ GatewayServer server = new GatewayServer.GatewayServerBuilder()
+ .gateway(new Gateway(new ConcurrentHashMap<String, Object>(), new CallbackClient(freePort)))
Review comment:
I guess the CallbackClient is not needed in 1.9 and 1.10. What's your thought?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12165:
URL: https://github.com/apache/flink/pull/12165#issuecomment-629158601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfa7a742fe1d051832355467854d50f03b376f91",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/166249593",
"triggerID" : "dfa7a742fe1d051832355467854d50f03b376f91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfa7a742fe1d051832355467854d50f03b376f91 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/166249593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12165:
URL: https://github.com/apache/flink/pull/12165#issuecomment-629142661
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dfa7a742fe1d051832355467854d50f03b376f91 (Fri Oct 16 10:35:41 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12165:
URL: https://github.com/apache/flink/pull/12165#issuecomment-629158601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dfa7a742fe1d051832355467854d50f03b376f91",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfa7a742fe1d051832355467854d50f03b376f91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfa7a742fe1d051832355467854d50f03b376f91 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org