You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2006/07/12 11:29:31 UTC
[jira] Commented: (HADOOP-237) Standard set of Performance Metrics
for Hadoop
[ http://issues.apache.org/jira/browse/HADOOP-237?page=comments#action_12420566 ]
Doug Cutting commented on HADOOP-237:
-------------------------------------
This mostly looks good to me.
The indentation is non-standard for Hadoop (using four spaces instead of two), many lines exceed 80 columns, the new package imports section is not separated by a blank line and in NameNode.java I think you add some unused fields.
More importantly, there seems to be a lot of duplicated code. It looks like we should probably add a MetricsReporter base class whose constructor constructs the context, record, etc. This should log rather than ignore exceptions. Then it can have reportMetric(String, int) and reportMetric(String, long) methods.
> Standard set of Performance Metrics for Hadoop
> ----------------------------------------------
>
> Key: HADOOP-237
> URL: http://issues.apache.org/jira/browse/HADOOP-237
> Project: Hadoop
> Type: Improvement
> Components: metrics
> Versions: 0.3.0
> Environment: All
> Reporter: Milind Bhandarkar
> Assignee: Milind Bhandarkar
> Attachments: hadoop-metrics.patch
>
> I am starting to use Hadoop's shiny new Metrics API to publish performance (and other) Metrics of running jobs and other daemons.
> Which performance metrics are people interested in seeing ? If possible, please group them according to modules, such as map-reduce, dfs, general-cluster-related etc. I will follow this process:
> 1. collect this list
> 2. assess feasibility of obtaining metric
> 3. assign context/record/metrics names
> 4. seek approval for names
> 5. instrument the code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira