You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2026/05/19 12:24:26 UTC

[PR] Tweak nightly docker image builds [solr]

janhoy opened a new pull request, #4448:
URL: https://github.com/apache/solr/pull/4448

   * All 10.x and main use Ubuntu **noble**, as is default
   * Switch version to 9.12.0-SNAPSHOT for branch_9x
   * Add builds for 9.11.0-SHAPSHOT from branch_9_11 (did not exist)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Tweak nightly docker image builds [solr]

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #4448:
URL: https://github.com/apache/solr/pull/4448#discussion_r3266250504


##########
.github/workflows/docker-nightly.yml:
##########
@@ -76,18 +76,38 @@ jobs:
 
           # branch_9x - Gradle on JDK17, Docker images with JRE17 (default) and JRE21
           - branch: branch_9x
-            version: 9.11.0-SNAPSHOT
+            version: 9.12.0-SNAPSHOT
             gradle-jdk: 17
             dist: full
             base-image: eclipse-temurin:17-jre-jammy
             tag-suffix: ''
           - branch: branch_9x
-            version: 9.11.0-SNAPSHOT
+            version: 9.12.0-SNAPSHOT

Review Comment:
   I wonder if we perhaps could skip setting version and just rely on the `project.version` already defined on each branch, and thus avoid having to bump this workflow file after each release.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Tweak nightly docker image builds [solr]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4448:
URL: https://github.com/apache/solr/pull/4448#issuecomment-4488198012

   > Can we perhaps avoid running full Crave.io tests for PRs like this - that only modify .github/*?
   
   and changelog.  I'll put up a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Tweak nightly docker image builds [solr]

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #4448:
URL: https://github.com/apache/solr/pull/4448#issuecomment-4488118821

   @dsmiley Can we perhaps avoid running full Crave.io tests for PRs like this - that only modify `.github/*`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Tweak nightly docker image builds [solr]

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #4448:
URL: https://github.com/apache/solr/pull/4448#discussion_r3266381103


##########
.github/workflows/docker-nightly.yml:
##########
@@ -76,18 +76,38 @@ jobs:
 
           # branch_9x - Gradle on JDK17, Docker images with JRE17 (default) and JRE21
           - branch: branch_9x
-            version: 9.11.0-SNAPSHOT
+            version: 9.12.0-SNAPSHOT
             gradle-jdk: 17
             dist: full
             base-image: eclipse-temurin:17-jre-jammy
             tag-suffix: ''
           - branch: branch_9x
-            version: 9.11.0-SNAPSHOT
+            version: 9.12.0-SNAPSHOT

Review Comment:
   Rewrote the workflow to not require **version** and instead fall back to the branch default version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Tweak nightly docker image builds [solr]

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #4448:
URL: https://github.com/apache/solr/pull/4448


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org