[GitHub] [beam] lukecwik commented on a change in pull request #16982: [BEAM-13015] Clarify ownership of the list for state caching across bundles

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #16982:
URL: https://github.com/apache/beam/pull/16982#discussion_r832824705



##########
File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/BagUserState.java
##########
@@ -141,6 +141,7 @@ public void asyncClose() throws Exception {
 
     // Modify the underlying cached state depending on the mutations performed
     if (isCleared) {
+      // Note this takes ownership of newValues. This object is no longer used after it has been closed.

Review comment:
       ```suggestion
         // Note this takes ownership of newValues. This object is no longer used after it has been
         // closed.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org