You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Brian Byrne <bb...@confluent.io> on 2019/10/29 16:39:00 UTC

[VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Hello all,

I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
functionality, linked here: https://cwiki.apache.org/confluence/x/ww-3Bw

Thanks,
Brian

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Viktor Somogyi-Vass <vi...@gmail.com>.
No problem :)
I also agree that it should be out of scope right now.

On Thu, Oct 31, 2019 at 10:10 PM Colin McCabe <cm...@apache.org> wrote:

> Sorry, that should read "Hi Viktor",....    -C.
>
> On Thu, Oct 31, 2019, at 14:08, Colin McCabe wrote:
> > Hi Vikto,
> >
> > That's an interesting idea.  However, I think it's better to consider
> > it outside the context of this KIP.  I think one-letter abbreviations
> > would be controversial, and aren't really related to fixing the ZK
> > dependency here.
> >
> > +1 (binding).  Thanks, Brian.
> >
> > best,
> > Colin
> >
> >
> > On Thu, Oct 31, 2019, at 07:20, Viktor Somogyi-Vass wrote:
> > > Hi Brian,
> > >
> > > I was just asking it because of curiosity although I do think it would
> be
> > > useful but it should be done on all tools to keep them consistent.
> > > Perhaps it could be a future consideration.
> > >
> > > I'm +1 on the KIP (non-binding).
> > >
> > > Viktor
> > >
> > > On Wed, Oct 30, 2019 at 5:50 PM Brian Byrne <bb...@confluent.io>
> wrote:
> > >
> > > > Hi Viktor,
> > > >
> > > > That's a possibility, however there doesn't appear to be precedent
> for
> > > > one-letter abbreviations with the Kafka commands, so going with the
> current
> > > > flags seemed less controversial. I'm not against it if there's a
> consensus
> > > > that adding {-b, -bl, -u, -c, -t} is better, but as of now, you're
> the
> > > > first to voice it.
> > > >
> > > > Thanks,
> > > > Brian
> > > >
> > > > On Wed, Oct 30, 2019 at 5:01 AM Viktor Somogyi-Vass <
> > > > viktorsomogyi@gmail.com>
> > > > wrote:
> > > >
> > > > > Hi Brian,
> > > > >
> > > > > Have you thought about having one letter abbreviations like '-b'
> for
> > > > > --brokers etc.?
> > > > >
> > > > > Thanks,
> > > > > Viktor
> > > > >
> > > > > On Tue, Oct 29, 2019 at 5:39 PM Brian Byrne <bb...@confluent.io>
> wrote:
> > > > >
> > > > > > Hello all,
> > > > > >
> > > > > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > > > > > functionality, linked here:
> > > > https://cwiki.apache.org/confluence/x/ww-3Bw
> > > > > >
> > > > > > Thanks,
> > > > > > Brian
> > > > > >
> > > > >
> > > >
> > >
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Colin McCabe <cm...@apache.org>.
Sorry, that should read "Hi Viktor",....    -C.

On Thu, Oct 31, 2019, at 14:08, Colin McCabe wrote:
> Hi Vikto,
> 
> That's an interesting idea.  However, I think it's better to consider 
> it outside the context of this KIP.  I think one-letter abbreviations 
> would be controversial, and aren't really related to fixing the ZK 
> dependency here.
> 
> +1 (binding).  Thanks, Brian.
> 
> best,
> Colin
> 
> 
> On Thu, Oct 31, 2019, at 07:20, Viktor Somogyi-Vass wrote:
> > Hi Brian,
> > 
> > I was just asking it because of curiosity although I do think it would be
> > useful but it should be done on all tools to keep them consistent.
> > Perhaps it could be a future consideration.
> > 
> > I'm +1 on the KIP (non-binding).
> > 
> > Viktor
> > 
> > On Wed, Oct 30, 2019 at 5:50 PM Brian Byrne <bb...@confluent.io> wrote:
> > 
> > > Hi Viktor,
> > >
> > > That's a possibility, however there doesn't appear to be precedent for
> > > one-letter abbreviations with the Kafka commands, so going with the current
> > > flags seemed less controversial. I'm not against it if there's a consensus
> > > that adding {-b, -bl, -u, -c, -t} is better, but as of now, you're the
> > > first to voice it.
> > >
> > > Thanks,
> > > Brian
> > >
> > > On Wed, Oct 30, 2019 at 5:01 AM Viktor Somogyi-Vass <
> > > viktorsomogyi@gmail.com>
> > > wrote:
> > >
> > > > Hi Brian,
> > > >
> > > > Have you thought about having one letter abbreviations like '-b' for
> > > > --brokers etc.?
> > > >
> > > > Thanks,
> > > > Viktor
> > > >
> > > > On Tue, Oct 29, 2019 at 5:39 PM Brian Byrne <bb...@confluent.io> wrote:
> > > >
> > > > > Hello all,
> > > > >
> > > > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > > > > functionality, linked here:
> > > https://cwiki.apache.org/confluence/x/ww-3Bw
> > > > >
> > > > > Thanks,
> > > > > Brian
> > > > >
> > > >
> > >
> >

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Colin McCabe <cm...@apache.org>.
Hi Vikto,

That's an interesting idea.  However, I think it's better to consider it outside the context of this KIP.  I think one-letter abbreviations would be controversial, and aren't really related to fixing the ZK dependency here.

+1 (binding).  Thanks, Brian.

best,
Colin


On Thu, Oct 31, 2019, at 07:20, Viktor Somogyi-Vass wrote:
> Hi Brian,
> 
> I was just asking it because of curiosity although I do think it would be
> useful but it should be done on all tools to keep them consistent.
> Perhaps it could be a future consideration.
> 
> I'm +1 on the KIP (non-binding).
> 
> Viktor
> 
> On Wed, Oct 30, 2019 at 5:50 PM Brian Byrne <bb...@confluent.io> wrote:
> 
> > Hi Viktor,
> >
> > That's a possibility, however there doesn't appear to be precedent for
> > one-letter abbreviations with the Kafka commands, so going with the current
> > flags seemed less controversial. I'm not against it if there's a consensus
> > that adding {-b, -bl, -u, -c, -t} is better, but as of now, you're the
> > first to voice it.
> >
> > Thanks,
> > Brian
> >
> > On Wed, Oct 30, 2019 at 5:01 AM Viktor Somogyi-Vass <
> > viktorsomogyi@gmail.com>
> > wrote:
> >
> > > Hi Brian,
> > >
> > > Have you thought about having one letter abbreviations like '-b' for
> > > --brokers etc.?
> > >
> > > Thanks,
> > > Viktor
> > >
> > > On Tue, Oct 29, 2019 at 5:39 PM Brian Byrne <bb...@confluent.io> wrote:
> > >
> > > > Hello all,
> > > >
> > > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > > > functionality, linked here:
> > https://cwiki.apache.org/confluence/x/ww-3Bw
> > > >
> > > > Thanks,
> > > > Brian
> > > >
> > >
> >
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Viktor Somogyi-Vass <vi...@gmail.com>.
Hi Brian,

I was just asking it because of curiosity although I do think it would be
useful but it should be done on all tools to keep them consistent.
Perhaps it could be a future consideration.

I'm +1 on the KIP (non-binding).

Viktor

On Wed, Oct 30, 2019 at 5:50 PM Brian Byrne <bb...@confluent.io> wrote:

> Hi Viktor,
>
> That's a possibility, however there doesn't appear to be precedent for
> one-letter abbreviations with the Kafka commands, so going with the current
> flags seemed less controversial. I'm not against it if there's a consensus
> that adding {-b, -bl, -u, -c, -t} is better, but as of now, you're the
> first to voice it.
>
> Thanks,
> Brian
>
> On Wed, Oct 30, 2019 at 5:01 AM Viktor Somogyi-Vass <
> viktorsomogyi@gmail.com>
> wrote:
>
> > Hi Brian,
> >
> > Have you thought about having one letter abbreviations like '-b' for
> > --brokers etc.?
> >
> > Thanks,
> > Viktor
> >
> > On Tue, Oct 29, 2019 at 5:39 PM Brian Byrne <bb...@confluent.io> wrote:
> >
> > > Hello all,
> > >
> > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > > functionality, linked here:
> https://cwiki.apache.org/confluence/x/ww-3Bw
> > >
> > > Thanks,
> > > Brian
> > >
> >
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Brian Byrne <bb...@confluent.io>.
Hi Viktor,

That's a possibility, however there doesn't appear to be precedent for
one-letter abbreviations with the Kafka commands, so going with the current
flags seemed less controversial. I'm not against it if there's a consensus
that adding {-b, -bl, -u, -c, -t} is better, but as of now, you're the
first to voice it.

Thanks,
Brian

On Wed, Oct 30, 2019 at 5:01 AM Viktor Somogyi-Vass <vi...@gmail.com>
wrote:

> Hi Brian,
>
> Have you thought about having one letter abbreviations like '-b' for
> --brokers etc.?
>
> Thanks,
> Viktor
>
> On Tue, Oct 29, 2019 at 5:39 PM Brian Byrne <bb...@confluent.io> wrote:
>
> > Hello all,
> >
> > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > functionality, linked here: https://cwiki.apache.org/confluence/x/ww-3Bw
> >
> > Thanks,
> > Brian
> >
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Viktor Somogyi-Vass <vi...@gmail.com>.
Hi Brian,

Have you thought about having one letter abbreviations like '-b' for
--brokers etc.?

Thanks,
Viktor

On Tue, Oct 29, 2019 at 5:39 PM Brian Byrne <bb...@confluent.io> wrote:

> Hello all,
>
> I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> functionality, linked here: https://cwiki.apache.org/confluence/x/ww-3Bw
>
> Thanks,
> Brian
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Jose Armando Garcia Sancio <js...@confluent.io>.
Hi Brian,

LGTM. +1 (non-binding)

On Thu, Nov 7, 2019 at 3:28 PM Colin McCabe <cm...@apache.org> wrote:

> Hi Brian,
>
> Thanks for the KIP.  +1 (binding).
>
> best,
> Colin
>
>
> On Thu, Nov 7, 2019, at 08:41, Brian Byrne wrote:
> > Hello all,
> >
> > Ping. Any further votes or opinions?
> >
> > Thanks,
> > Brian
> >
> > On Tue, Oct 29, 2019 at 9:39 AM Brian Byrne <bb...@confluent.io> wrote:
> >
> > > Hello all,
> > >
> > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > > functionality, linked here:
> https://cwiki.apache.org/confluence/x/ww-3Bw
> > >
> > > Thanks,
> > > Brian
> > >
> >
>


-- 
-Jose

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Colin McCabe <cm...@apache.org>.
Hi Brian,

Thanks for the KIP.  +1 (binding).

best,
Colin


On Thu, Nov 7, 2019, at 08:41, Brian Byrne wrote:
> Hello all,
> 
> Ping. Any further votes or opinions?
> 
> Thanks,
> Brian
> 
> On Tue, Oct 29, 2019 at 9:39 AM Brian Byrne <bb...@confluent.io> wrote:
> 
> > Hello all,
> >
> > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > functionality, linked here: https://cwiki.apache.org/confluence/x/ww-3Bw
> >
> > Thanks,
> > Brian
> >
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Brian Byrne <bb...@confluent.io>.
Excuse me, that should read "4 binding +1 votes".

Brian

On Wed, Nov 13, 2019 at 9:26 AM Brian Byrne <bb...@confluent.io> wrote:

> Hello all,
>
> With 5 binding +1 votes from Colin McCabe, Gwen Shapira, Manikumar Reddy,
> and Jason Gustafson, and 2 non-binding +1 votes from Viktor Somogyi-Vass
> and Jose Armando Garcia Sancio, the vote passes.
>
> Thanks,
> Brian
>
> On Fri, Nov 8, 2019 at 2:23 PM Brian Byrne <bb...@confluent.io> wrote:
>
>>
>> Thanks everyone. Unless there's any additional input or issues raised,
>> I'll close the vote Monday morning approx 10 am PST.
>>
>> Brian
>>
>> On Thu, Nov 7, 2019 at 10:32 PM Jason Gustafson <ja...@confluent.io>
>> wrote:
>>
>>> +1 Looking forward to this. I love the quality-of-life changes.
>>>
>>> On Thu, Nov 7, 2019 at 7:00 PM Manikumar <ma...@gmail.com>
>>> wrote:
>>>
>>> > +1 (binding), Thanks for the KIP.
>>> >
>>> >
>>> >
>>> > On Fri, Nov 8, 2019 at 8:14 AM Gwen Shapira <gw...@confluent.io> wrote:
>>> >
>>> > > +1 (binding)
>>> > >
>>> > > Thank you.
>>> > >
>>> > > On Thu, Nov 7, 2019, 8:41 AM Brian Byrne <bb...@confluent.io>
>>> wrote:
>>> > >
>>> > > > Hello all,
>>> > > >
>>> > > > Ping. Any further votes or opinions?
>>> > > >
>>> > > > Thanks,
>>> > > > Brian
>>> > > >
>>> > > > On Tue, Oct 29, 2019 at 9:39 AM Brian Byrne <bb...@confluent.io>
>>> > wrote:
>>> > > >
>>> > > > > Hello all,
>>> > > > >
>>> > > > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
>>> > > > > functionality, linked here:
>>> > > https://cwiki.apache.org/confluence/x/ww-3Bw
>>> > > > >
>>> > > > > Thanks,
>>> > > > > Brian
>>> > > > >
>>> > > >
>>> > >
>>> >
>>>
>>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Brian Byrne <bb...@confluent.io>.
Hello all,

With 5 binding +1 votes from Colin McCabe, Gwen Shapira, Manikumar Reddy,
and Jason Gustafson, and 2 non-binding +1 votes from Viktor Somogyi-Vass
and Jose Armando Garcia Sancio, the vote passes.

Thanks,
Brian

On Fri, Nov 8, 2019 at 2:23 PM Brian Byrne <bb...@confluent.io> wrote:

>
> Thanks everyone. Unless there's any additional input or issues raised,
> I'll close the vote Monday morning approx 10 am PST.
>
> Brian
>
> On Thu, Nov 7, 2019 at 10:32 PM Jason Gustafson <ja...@confluent.io>
> wrote:
>
>> +1 Looking forward to this. I love the quality-of-life changes.
>>
>> On Thu, Nov 7, 2019 at 7:00 PM Manikumar <ma...@gmail.com>
>> wrote:
>>
>> > +1 (binding), Thanks for the KIP.
>> >
>> >
>> >
>> > On Fri, Nov 8, 2019 at 8:14 AM Gwen Shapira <gw...@confluent.io> wrote:
>> >
>> > > +1 (binding)
>> > >
>> > > Thank you.
>> > >
>> > > On Thu, Nov 7, 2019, 8:41 AM Brian Byrne <bb...@confluent.io> wrote:
>> > >
>> > > > Hello all,
>> > > >
>> > > > Ping. Any further votes or opinions?
>> > > >
>> > > > Thanks,
>> > > > Brian
>> > > >
>> > > > On Tue, Oct 29, 2019 at 9:39 AM Brian Byrne <bb...@confluent.io>
>> > wrote:
>> > > >
>> > > > > Hello all,
>> > > > >
>> > > > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
>> > > > > functionality, linked here:
>> > > https://cwiki.apache.org/confluence/x/ww-3Bw
>> > > > >
>> > > > > Thanks,
>> > > > > Brian
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Brian Byrne <bb...@confluent.io>.
Thanks everyone. Unless there's any additional input or issues raised, I'll
close the vote Monday morning approx 10 am PST.

Brian

On Thu, Nov 7, 2019 at 10:32 PM Jason Gustafson <ja...@confluent.io> wrote:

> +1 Looking forward to this. I love the quality-of-life changes.
>
> On Thu, Nov 7, 2019 at 7:00 PM Manikumar <ma...@gmail.com>
> wrote:
>
> > +1 (binding), Thanks for the KIP.
> >
> >
> >
> > On Fri, Nov 8, 2019 at 8:14 AM Gwen Shapira <gw...@confluent.io> wrote:
> >
> > > +1 (binding)
> > >
> > > Thank you.
> > >
> > > On Thu, Nov 7, 2019, 8:41 AM Brian Byrne <bb...@confluent.io> wrote:
> > >
> > > > Hello all,
> > > >
> > > > Ping. Any further votes or opinions?
> > > >
> > > > Thanks,
> > > > Brian
> > > >
> > > > On Tue, Oct 29, 2019 at 9:39 AM Brian Byrne <bb...@confluent.io>
> > wrote:
> > > >
> > > > > Hello all,
> > > > >
> > > > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > > > > functionality, linked here:
> > > https://cwiki.apache.org/confluence/x/ww-3Bw
> > > > >
> > > > > Thanks,
> > > > > Brian
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Jason Gustafson <ja...@confluent.io>.
+1 Looking forward to this. I love the quality-of-life changes.

On Thu, Nov 7, 2019 at 7:00 PM Manikumar <ma...@gmail.com> wrote:

> +1 (binding), Thanks for the KIP.
>
>
>
> On Fri, Nov 8, 2019 at 8:14 AM Gwen Shapira <gw...@confluent.io> wrote:
>
> > +1 (binding)
> >
> > Thank you.
> >
> > On Thu, Nov 7, 2019, 8:41 AM Brian Byrne <bb...@confluent.io> wrote:
> >
> > > Hello all,
> > >
> > > Ping. Any further votes or opinions?
> > >
> > > Thanks,
> > > Brian
> > >
> > > On Tue, Oct 29, 2019 at 9:39 AM Brian Byrne <bb...@confluent.io>
> wrote:
> > >
> > > > Hello all,
> > > >
> > > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > > > functionality, linked here:
> > https://cwiki.apache.org/confluence/x/ww-3Bw
> > > >
> > > > Thanks,
> > > > Brian
> > > >
> > >
> >
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Manikumar <ma...@gmail.com>.
+1 (binding), Thanks for the KIP.



On Fri, Nov 8, 2019 at 8:14 AM Gwen Shapira <gw...@confluent.io> wrote:

> +1 (binding)
>
> Thank you.
>
> On Thu, Nov 7, 2019, 8:41 AM Brian Byrne <bb...@confluent.io> wrote:
>
> > Hello all,
> >
> > Ping. Any further votes or opinions?
> >
> > Thanks,
> > Brian
> >
> > On Tue, Oct 29, 2019 at 9:39 AM Brian Byrne <bb...@confluent.io> wrote:
> >
> > > Hello all,
> > >
> > > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > > functionality, linked here:
> https://cwiki.apache.org/confluence/x/ww-3Bw
> > >
> > > Thanks,
> > > Brian
> > >
> >
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Gwen Shapira <gw...@confluent.io>.
+1 (binding)

Thank you.

On Thu, Nov 7, 2019, 8:41 AM Brian Byrne <bb...@confluent.io> wrote:

> Hello all,
>
> Ping. Any further votes or opinions?
>
> Thanks,
> Brian
>
> On Tue, Oct 29, 2019 at 9:39 AM Brian Byrne <bb...@confluent.io> wrote:
>
> > Hello all,
> >
> > I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> > functionality, linked here: https://cwiki.apache.org/confluence/x/ww-3Bw
> >
> > Thanks,
> > Brian
> >
>

Re: [VOTE] KIP-543: Expand ConfigCommand's non-ZK functionality

Posted by Brian Byrne <bb...@confluent.io>.
Hello all,

Ping. Any further votes or opinions?

Thanks,
Brian

On Tue, Oct 29, 2019 at 9:39 AM Brian Byrne <bb...@confluent.io> wrote:

> Hello all,
>
> I'd like to call a vote on KIP-543: Expand ConfigCommand's non-ZK
> functionality, linked here: https://cwiki.apache.org/confluence/x/ww-3Bw
>
> Thanks,
> Brian
>