You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by ygy <gi...@git.apache.org> on 2015/06/23 16:53:43 UTC

[GitHub] incubator-brooklyn pull request: Fixing Integration tests for 0.7....

GitHub user ygy opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/712

    Fixing Integration tests for 0.7.0

    - io.brooklyn.camp.brooklyn.JavaWebAppsIntegrationTest.testWithDbDeploy()
    - io.brooklyn.camp.brooklyn.JavaWebAppsIntegrationTest.testWithPolicyDeploy()

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ygy/incubator-brooklyn fix/tests-0.7.0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/712.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #712
    
----
commit d6eb9d68815b91bfa7e8f9cede0d37f2e7f4f137
Author: Yavor Yanchev <ya...@yanchev.com>
Date:   2015-06-23T14:50:56Z

    Fixing Integration tests for 0.7.0
    
    - io.brooklyn.camp.brooklyn.JavaWebAppsIntegrationTest.testWithDbDeploy()
    - io.brooklyn.camp.brooklyn.JavaWebAppsIntegrationTest.testWithPolicyDeploy()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixing Integration tests for 0.7....

Posted by neykov <gi...@git.apache.org>.

Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/712#issuecomment-114872212
  
    Good to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixing Integration tests for 0.7....

Posted by ygy <gi...@git.apache.org>.

Github user ygy commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/712#issuecomment-114550415
  
    @mikezaccardo it is using ```Tomcat8Server``` now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixing Integration tests for 0.7....

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/712


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixing Integration tests for 0.7....

Posted by mikezaccardo <gi...@git.apache.org>.

Github user mikezaccardo commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/712#issuecomment-114538527
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixing Integration tests for 0.7....

Posted by mikezaccardo <gi...@git.apache.org>.

Github user mikezaccardo commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/712#discussion_r33051726
  
    --- Diff: usage/camp/src/test/resources/java-web-app-simple.yaml ---
    @@ -21,8 +21,8 @@ description: Single JBoss using Brooklyn
     origin: https://github.com/apache/incubator-brooklyn
     location: localhost
     services:
    -- serviceType: brooklyn.entity.webapp.jboss.JBoss7Server
    -  name: jboss1
    +- serviceType: brooklyn.entity.webapp.tomcat.TomcatServer
    --- End diff --
    
    `Tomcat8ServerImpl` is an option here if you'd like to use a newer version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---